[Patch] Improve Advanced Object Info

[simon04]

I adapted the Advanced Object Info dialog to increase readability. The output is very similar to ​http://www.openstreetmap.org/browse/.

Any comments?

[bastiK]

Looks better, IMHO.

Minor things:

• Why remove the sorting of the primitives?
• The indentation for 'modified', 'deleted' and conflicts looks strage.
• i18n: The strings for translation are collected by a script that scans the source code for tr(...) and marktr(...) with string literals as arguments. So something like s="modified"; add(tr(s)); does not work.

[stoecker]

So something like s="modified"; add(tr(s)); does not work.

It must be "s=marktr("modified"); add(tr(s));" :-)

[simon04]

Replying to bastiK:

• Why remove the sorting of the primitives?

I worked on this patch before your commit. I have no strong opinion on this point. When sticking to the order of selection (w/o sorting), it gives more control to the user.

I'll adapt the patch to reflect your suggestions. Better committing after the stabilization phase?

[bastiK]

Replying to simon04:

Replying to bastiK:

• Why remove the sorting of the primitives?

I worked on this patch before your commit. I have no strong opinion on this point. When sticking to the order of selection (w/o sorting), it gives more control to the user.

The selection comes from a HashSet, so order is randomized.

Better committing after the stabilization phase?

Yes, unless you feel strongly about getting it into next tested.

[simon04]

I integrated your comments from above … I assume that I can commit this patch after the stabilization phase.

[bastiK]

Sure, go ahead.

Maybe we can improve display of conflicts?

Node: 739410997
  State: modified
  Data Set: 2c390c
  Edited at: 2011-09-06T10:15:06Z
  Edited by: alv (4660)
  Version: 3
  In changeset: 9225884
  Tags: 
    "capacity"="9"
    "description"="pyöräteline"
    "amenity"="bicycle_parking"
  Coordinates: 60.2195182, 25.0042714
  Coordinates (projected): 2783462.7599048135, 8448774.202314496
  In conflict with: 
Node: 739410997
  State: modified
  Data Set: 1f3b536
  Edited at: 2011-09-06T10:15:06Z
  Edited by: alv (4660)
  Version: 3
  In changeset: 9225884
  Tags: 
    "capacity"="8"
    "description"="pyöräteline"
    "amenity"="bicycle_parking"
  Coordinates: 60.21942278701698, 25.00446350188961
  Coordinates (projected): 2783484.1445893454, 8448752.817629961

[simon04]

Replying to bastiK:

Maybe we can improve display of conflicts?

Of course, what do you suggest? Probably In conflict with Node: 739410997 (cf. your example)?

[bastiK]

Replying to simon04:

Replying to bastiK:

Maybe we can improve display of conflicts?

Of course, what do you suggest?

Not sure, but looks a little strange right now.

Probably In conflict with Node: 739410997 (cf. your example)?

Ok, and with 0 indentation for that line?

[bastiK]

Minor stuff:

• Would be nice, to display number of nodes / members, for ways and relations.
• For way nodes, you don't need the prefix Node: in each line.
• Role should be in quotes.

[simon04]

In [4410/josm]:

fix #6741 - improve Advanced Object Info - feel free to enter any suggestion/comment to the existing ticket