loading of default imagery sources sometimes fails

[bastiK]

[4198] broke the loading of default imagery sources:

Index: trunk/src/org/openstreetmap/josm/gui/preferences/ImageryPreference.java
===================================================================
--- a/trunk/src/org/openstreetmap/josm/gui/preferences/ImageryPreference.java
+++ b/trunk/src/org/openstreetmap/josm/gui/preferences/ImageryPreference.java
@@ -836,6 +836,6 @@
 
     public static void initialize() {
+        ImageryLayerInfo.instance.loadDefaults(false);
         ImageryLayerInfo.instance.load();
-        ImageryLayerInfo.instance.loadDefaults(false);
         OffsetBookmark.loadBookmarks();
         Main.main.menu.imageryMenu.refreshImageryMenu();

In combination with

    public void load() {
        layers.clear();

this discards the layers added in loadDefaults(false).

[bastiK]

In [4216/josm]:

see #6562 - loading of default imagery sources broken

[bastiK]

[4216] should fix the problem

[stoecker]

Your patch kills the attribution copy function, as this need the defaults to be loaded before the defined entries. Can't you simply move the clear() to initialize where it belongs?

[stoecker]

Sorry, ignore last comment. Need to wake up first before I can read patches :-)

[skyper]

I still have this issue from time to time due to bad connections. Strange the connection is much better with ssl than without !

Once the default list is not downloaded on your first run of JOSM and the connections fails the list will stay empty until user manually adds servers.

Would be nice if JOSM would add the default list if the list is empty (with an option to leave it empty if intended ?).

Thanks.

[skyper]

Did not happen for a long time