select and edit actions performed in inactive layer.

[skyper]

I have an GPX marker layer as active layer but I am still able to select and edit the last active data layer and the segment numbers of the inactive data layer are still coloured.

Using /usr/lib/jvm/java-6-openjdk/bin/java to execute josm.
Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-06-27 01:31:44
Last Changed Author: stoecker
Revision: 4177
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-06-26 17:45:48 +0200 (Sun, 26 Jun 2011)
Last Changed Rev: 4177

GET http://api.openstreetmap.org/api/capabilities... OK

loading plugin 'reltoolbox' (version 26174)
loading plugin 'undelete' (version 26174)
loading plugin 'alignways' (version 26174)
loading plugin 'Curves' (version 16.master-4f7c5a0)
loading plugin 'reverter' (version 26174)
loading plugin 'buildings_tools' (version 26174)
loading plugin 'multipoly-convert' (version 26174)
Silent shortcut conflict: 'tools:multipolyconv' moved by 'tools:mirror' to 'Alt+Umschalt+M'.
loading plugin 'waydownloader' (version 26174)
loading plugin 'OpeningHoursEditor' (version 26174)
loading plugin 'utilsplugin2' (version 26174)
Silent shortcut conflict: 'tools:intway' moved by 'tools:alignways' to 'Alt+Umschalt+I'.
loading plugin 'terracer' (version 26174)
Silent shortcut conflict: 'tools:Terracer' moved by 'tool:revert' to 'Alt+Umschalt+T'.
Silent shortcut conflict: 'tools:ReverseTerrace' moved by 'tools:tagbuffer' to 'Alt+Umschalt+R'.
RemoteControl::Accepting connections on port 8111
Open file: /media/GARMIN/Garmin/GPX/Wegpunkte_26-JUN-11.gpx (3313 bytes)
Silent shortcut conflict: 'mapmode:parallel' moved by 'tools:splitobject' to 'Alt+Umschalt+P'.
Silent shortcut conflict: 'subwindow:properties' moved by 'mapmode:parallel' to 'Alt+B'.
Silent shortcut conflict: 'properties:add' moved by 'subwindow:properties' to 'Alt+C'.
Silent shortcut conflict: 'subwindow:selection' moved by 'tools:Terracer' to 'Alt+D'.
Silent shortcut conflict: 'subwindow:relations' moved by 'tools:ReverseTerrace' to 'Alt+R'.
Silent shortcut conflict: 'subwindow:conflict' moved by 'properties:add' to 'Alt+Umschalt+C'.
Silent shortcut conflict: 'subwindow:mappaint' moved by 'tools:multipolyconv' to 'Alt+G'.
Silent shortcut conflict: 'reltoolbox:changerole' moved by 'tools:tagbuffer' to 'H'.
Registered toolbar action without name: relcontext.RelContextDialog$EnterRoleAction
Silent shortcut conflict: 'reltoolbox:find' moved by 'system:find' to 'Strg+Alt+F'.

[stoecker]

Closed as duplicate of #6447.

[skyper]

Replying to stoecker:

Closed as duplicate of #6447.

I am not sure if this is really a duplicate because with #6447 the behaviour stoped after added a new node to active layer but with the marker layer I was able to edit all the way.
By the way, it even was not that bad cause I had not to switch layer all the time, also it is kind of dangerous cause unexpected.

[olejorgenb]

Agree, it's probably the same issue as #6875 though

[skyper]

Have to check if this is fixed. No marker layer at the moment.

[skyper]

I have tested with:

track_Pontiac_CZ.zip:ticket:6912​

1. open marker file
2. download data
3. selected a node in data layer
4. activate marker layer
5. add tag (Alt+A)
6. enter "access=no"

Exception.

I ended up with #7491 and the tag was added to the node in data layer

[skyper]

I did test again. No exceptions but if you use a gpx-layer you are still able to add/remove tags in the data layer and moving the gpx-trace around moves everything (gpx-trace,gpx-markers and the objects in data layer).

r5226

[mrwojo]

This is also reproducible when switching to the validator's "Validation errors" layer.

Several actions, such as SelectAllAction, are enabled if getEditLayer() != null. Perhaps the intention here is closer to:

getEditLayer() != null && getEditLayer().equals(Main.main.getActiveLayer())

Several other actions are affected as well.