Modify

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#6510 closed defect (fixed)

[Patch] validator complains about natural=tree_row being an unclosed way

Reported by: scai Owned by: team
Priority: normal Component: Core validator
Version: Keywords:
Cc: scai

Description

Hi,

JOSM's validator complains about natural=tree_row being an unclosed way although this tag is only applied to ways. Instead, it should complain if applying it to nodes or areas.

Regards,
Alex

Attachments (1)

6510.patch (687 bytes) - added by simon04 22 months ago.

Download all attachments as: .zip

Change History (5)

Changed 22 months ago by simon04

comment:1 follow-up: Changed 22 months ago by simon04

The attached patch removes the warning of tree_row being not closed.

For the opposite direction, i.e., a warning when being closed, I could not find a test.

Btw: instead of hard coding of tests in UnclosedWays, one could directly fetch the correct usage of tags on nodes/ways/areas/relations via the presets, right?

comment:2 Changed 22 months ago by simon04

  • Summary changed from validator complains about natural=tree_row being an unclosed way to [Patch] validator complains about natural=tree_row being an unclosed way

comment:3 Changed 22 months ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

In [4294/josm]:

fix #6510 - patch by simon04 - validator complains about natural=tree_row being an unclosed way

comment:4 in reply to: ↑ 1 Changed 22 months ago by stoecker

Replying to simon04:

Btw: instead of hard coding of tests in UnclosedWays, one could directly fetch the correct usage of tags on nodes/ways/areas/relations via the presets, right?

Validator code has not always been updated to the current state, so there is probably a lot of improvement possible in this part of the software.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.