Modify

Opened 13 years ago

Closed 10 years ago

#6416 closed defect (irreproducible)

IllegalArgumentException: "Relation member cannot be null" after upload while relation editor open

Reported by: dieterdreist Owned by: stoecker
Priority: normal Milestone:
Component: Core Version: latest
Keywords: relation editor upload Cc:

Description (last modified by Don-vip)

Happened after upload. I had a relation editor window open, uploaded, and after successful upload hit "OK" to close the relation editor.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-05-31 01:31:37
Last Changed Author: bastiK
Revision: 4105
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-05-30 19:22:31 +0200 (Mon, 30 May 2011)
Last Changed Rev: 4105

Identification: JOSM/1.5 (4105 en)
Memory Usage: 669 MB / 989 MB (93 MB allocated, but free)
Java version: 1.6.0_24, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Linux

Dataset consistency test:
[NO DATASET] {Way id=-45153 version=0 MVD nodes=[]} is referenced by {Relation id=1230678 version=20 VT [way 82203378, way 82211689, way 82211686, way 82211679, way 82211674, way 82211693, way 82207013, way 82207006, way 82275397, way 82203358, way 82203373, way 82203371, way 23680707, way 82198936, way 68593932, way 82275395, way 82275390, way 68607102, way 82122221, way 68607126, way 68579506, way 82072579, way 82072589, way 82072602, way 82072596, way 82072565, way 82072585, way 82072615, way 82072577, way 82072588, way 60353607, way 82122215, way 82072611, way 82122223, way 60353583, way 60353606, way 82072580, way 82072563, way 82097433, way 82097439, way 82097441, way 82097434, way 82088034, way 81550508, way 54542134, way 81549467, way 81549464, way 81549454, way 73915848, way 61730323, way 61730324, way 34995598, way 53271805, way 82263731, way 34994577, way 82263723, way 114666428, way 114661462, way 34994572, way 34994093, way 34994091, way 114671180, way 82263727, way 82263717, way 82263715, way 114661019, way 114671176, way 114660375, way 114671169, way 114676357, way 114673641, way 114657803, way 114673636, way 60355797, way 114657806, way 114657417, way 114682318, way 34995601, way 81547644, way 114576514, way 114682313, way 114682316, way 114576499, way 80026607, way 80026608, way 114682321, way 114576496, way 66466993, way 60355796, way 60355836, way 60355795, way 66466991, way 66466992, way 25535226, way 62079613, way 62108119, way 41603024, way 62108133, way 62111100, way 115768670, way 115768672, way 115835834, way 115835824, way 115835817, way 115835813, way 115835820, way 115771384, way 63093980, way 115773619, way 115839208, way 115848799, way 63108632, way 115848797, way 115848798, way 63094004, way 115848361, way 115841479, way 115841478, way -45153, way 114671173, way 111846595, way 114671946, node 957021161, node 957021072, node 956308366, node 956309051, node 956309103, node 956308546, node 956308949, node 956309135, node 956308651, node 955907764, node 1298374478, node 1298413370, node 1307012877, node 1307012893, node 1307012900, node 1307012914, node 1307012874, node 1307057000, node 1307057067, node 1307057162, node 1307612759, node 1307612767, node 1307612761, node 1307612765, node 1307637170, node 1307687366, node 1307691477, node 1307691493, node 1307687369, node 1307694495, node 1307698922, node 1307698920]} but not found in dataset
[DELETED REFERENCED] {Relation id=1230678 version=20 VT [way 82203378, way 82211689, way 82211686, way 82211679, way 82211674, way 82211693, way 82207013, way 82207006, way 82275397, way 82203358, way 82203373, way 82203371, way 23680707, way 82198936, way 68593932, way 82275395, way 82275390, way 68607102, way 82122221, way 68607126, way 68579506, way 82072579, way 82072589, way 82072602, way 82072596, way 82072565, way 82072585, way 82072615, way 82072577, way 82072588, way 60353607, way 82122215, way 82072611, way 82122223, way 60353583, way 60353606, way 82072580, way 82072563, way 82097433, way 82097439, way 82097441, way 82097434, way 82088034, way 81550508, way 54542134, way 81549467, way 81549464, way 81549454, way 73915848, way 61730323, way 61730324, way 34995598, way 53271805, way 82263731, way 34994577, way 82263723, way 114666428, way 114661462, way 34994572, way 34994093, way 34994091, way 114671180, way 82263727, way 82263717, way 82263715, way 114661019, way 114671176, way 114660375, way 114671169, way 114676357, way 114673641, way 114657803, way 114673636, way 60355797, way 114657806, way 114657417, way 114682318, way 34995601, way 81547644, way 114576514, way 114682313, way 114682316, way 114576499, way 80026607, way 80026608, way 114682321, way 114576496, way 66466993, way 60355796, way 60355836, way 60355795, way 66466991, way 66466992, way 25535226, way 62079613, way 62108119, way 41603024, way 62108133, way 62111100, way 115768670, way 115768672, way 115835834, way 115835824, way 115835817, way 115835813, way 115835820, way 115771384, way 63093980, way 115773619, way 115839208, way 115848799, way 63108632, way 115848797, way 115848798, way 63094004, way 115848361, way 115841479, way 115841478, way -45153, way 114671173, way 111846595, way 114671946, node 957021161, node 957021072, node 956308366, node 956309051, node 956309103, node 956308546, node 956308949, node 956309135, node 956308651, node 955907764, node 1298374478, node 1298413370, node 1307012877, node 1307012893, node 1307012900, node 1307012914, node 1307012874, node 1307057000, node 1307057067, node 1307057162, node 1307612759, node 1307612767, node 1307612761, node 1307612765, node 1307637170, node 1307687366, node 1307691477, node 1307691493, node 1307687369, node 1307694495, node 1307698922, node 1307698920]} refers to deleted primitive {Way id=-45153 version=0 MVD nodes=[]}


Plugin: ImportImagePlugin (25934)
Plugin: PicLayer (25219)
Plugin: alignways (25199)
Plugin: buildings_tools (25905)
Plugin: dataimport (25192)
Plugin: osmarender (25371)
Plugin: pdfimport (25546)
Plugin: photo_geotagging (25199)
Plugin: public_transport (25192)
Plugin: restart (25199)
Plugin: reverter (26047)
Plugin: tagging-preset-tester (25191)
Plugin: undelete (26073)
Plugin: waypoint_search (25191)

java.lang.IllegalArgumentException: Relation member cannot be null
	at org.openstreetmap.josm.data.osm.RelationMember.<init>(RelationMember.java:123)
	at org.openstreetmap.josm.gui.conflict.pair.relation.RelationMemberListMergeModel.cloneEntryForMergedList(RelationMemberListMergeModel.java:99)
	at org.openstreetmap.josm.gui.conflict.pair.relation.RelationMemberListMergeModel.populate(RelationMemberListMergeModel.java:86)
	at org.openstreetmap.josm.gui.conflict.pair.relation.RelationMemberMerger.populate(RelationMemberMerger.java:59)
	at org.openstreetmap.josm.gui.conflict.pair.ConflictResolver.populate(ConflictResolver.java:251)
	at org.openstreetmap.josm.gui.dialogs.ConflictDialog.resolve(ConflictDialog.java:149)
	at org.openstreetmap.josm.gui.dialogs.ConflictDialog.access$000(ConflictDialog.java:58)
	at org.openstreetmap.josm.gui.dialogs.ConflictDialog$ResolveAction.actionPerformed(ConflictDialog.java:348)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
	at java.awt.Component.processMouseEvent(Component.java:6289)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6054)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4652)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4482)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4482)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:644)
	at java.awt.EventQueue.access$000(EventQueue.java:85)
	at java.awt.EventQueue$1.run(EventQueue.java:603)
	at java.awt.EventQueue$1.run(EventQueue.java:601)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:98)
	at java.awt.EventQueue$2.run(EventQueue.java:617)
	at java.awt.EventQueue$2.run(EventQueue.java:615)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:614)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Attachments (0)

Change History (8)

comment:1 by stoecker, 13 years ago

Owner: changed from team to dieterdreist
Status: newneedinfo

Can you reproduce this?

comment:2 by anonymous, 13 years ago

I cannot fully reproduce this at the moment, but there is some inconsistency in the relation editor. E.g. a multipolygon relation, 1 outer, 1 inner way.

1. open the relation editor for the relation
2. split the outer way in 2 in the map view
3. the relation editor shows only 2 members but the properties in the main view show membership in a relation with 3 members
4. hit OK in the relation editor (note that the relation still has only 2 members in this editor)
5. reopen the relation editor: it now has 3 members

same goes for the other way round (combine e.g. the 2 outer members from the example above, keep one, remove the other, the relation editor after this still shows 3 members, one closed outer (changes on combine) and one open outer (version 0, 0 nodes, id:0). After closing and reopening this is resolved.

Btw.: It seems that it is not possible any more to open more than one relation editor window for the same relation (this solves some issues and AFAIR at least for some time this was possible).

seems as if the initial problem is gone (or at least I cannot reproduce it, maybe just happens occasionally).

comment:3 by dieterdreist, 13 years ago

Owner: changed from dieterdreist to stoecker
Status: needinfonew

comment:4 by stoecker, 13 years ago

Generally we miss a realtime announcement for changes outside the relation editor. That it does not cause trouble in your example probably is caused by the fact, that you did not modify the relation between step 2 and 5.

comment:5 by Don-vip, 13 years ago

Description: modified (diff)

comment:6 by Don-vip, 11 years ago

Ticket #8619 has been marked as a duplicate of this ticket.

comment:7 by Don-vip, 10 years ago

Description: modified (diff)
Keywords: upload added
Summary: unhandled exceptionIllegalArgumentException: "Relation member cannot be null" after upload while relation editor open

comment:8 by stoecker, 10 years ago

Resolution: irreproducible
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain stoecker.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.