#6370 closed defect (fixed)
Reverter plugin is broken after core changes
| Reported by: | akks | Owned by: | Upliner |
|---|---|---|---|
| Priority: | major | Component: | Plugin reverter |
| Version: | Keywords: | ||
| Cc: |
Description
Now Reverter plugin throws NullPointerException instead of downloading changeset.
The same plugin version works ok at with JOSM rev 3965 (no not know, what exct revision broke it)
Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-05-21 01:31:32
Last Changed Author: bastiK
Revision: 4091
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-05-20 11:39:10 +0200 (Fri, 20 May 2011)
Last Changed Rev: 4091
Identification: JOSM/1.5 (4091 ru)
Memory Usage: 47 MB / 989 MB (16 MB allocated, but free)
Java version: 1.6.0_23, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows XP
Dataset consistency test: No problems found
Plugin: reverter (25578)
java.lang.NullPointerException
at org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor.close(PleaseWaitProgressMonitor.java:151)
at reverter.RevertChangesetAction$1.checkAndDownloadMissing(RevertChangesetAction.java:68)
at reverter.RevertChangesetAction$1.realRun(RevertChangesetAction.java:86)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:83)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:129)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Attachments (0)
Change History (8)
comment:1 Changed 2 years ago by akks
comment:2 Changed 2 years ago by akks
Unfortunately, it's our 4081 - MultiFetchServerObjectReader changed its behaviour (?). Do not know how to repair.
comment:3 Changed 2 years ago by akks
Reverter works OK if I use 4081 revision and MultiFetchServerObjectReader.java from 4080.
Stop working exactly after updating MultiFetchServerObjectReader.java to 4081.
comment:4 Changed 2 years ago by bastiK
- Resolution set to fixed
- Status changed from new to closed
Method signatures in MultiFetchServerObjectReader slightly changed, so plugin needed recompile [o26047]. NPE is a little strange, but should work now.
comment:5 Changed 2 years ago by akks
All works OK. There is also plugin TrustOSM that use MultiFetchServerObjectReader, but I do not know, is it working - it does not even compile due to some character encoding problem. After adding utf8 it cannot be built too. I added ticket for authors to notice the possible problem.
comment:6 Changed 2 years ago by skyper
- Resolution fixed deleted
- Status changed from closed to reopened
I can not revert node 1221699249 of changeset 7826133.
I get no message but the node is not moved back to previous position.
comment:7 follow-up: ↓ 8 Changed 2 years ago by Upliner
- Resolution set to fixed
- Status changed from reopened to closed
Fixed again by recompilation: [o26093]



4080 works, 4085 does not. Sorry, I have no more time these days..