Opened 2 years ago
Closed 2 years ago
#6359 closed enhancement (fixed)
Option for displaying a "12h clock" in openinghourseditor plugin
| Reported by: | rickmastfan67 | Owned by: | boman |
|---|---|---|---|
| Priority: | normal | Component: | Plugin openinghourseditor |
| Version: | latest | Keywords: | |
| Cc: |
Description
Is it possible to display the 12h clock if people want it (but of course using the 24h one for the input of data)?
I've created a mock up (that will be attached right after this ticket is made) that shows how I think it could be implemented.
Also, the checkbox in "openinghourseditor1.png" would stay clicked always *IF* somebody clicks it unless somebody unclicks in the future.
The reason I'm suggesting this is because it would make editing opening hours for North American (USA & Canada at least) users a lot easier because that's how it's displayed on signs for businesses.
Attachments (2)
Change History (9)
Changed 2 years ago by rickmastfan67
comment:1 Changed 2 years ago by boman
- Owner changed from team to boman
- Status changed from new to assigned
This Idea is good.
I will take a look in the next days if I can apply it.
And thanks for the two pictures, it makes it a lot more clear.
comment:2 Changed 2 years ago by rickmastfan67
boman, just was curious, but any update on this?
comment:3 follow-up: ↓ 4 Changed 2 years ago by boman
I think, the patch is ready until the weekend.
I was slightly thrown out of schedule.
I'm sorry for not letting you know about the delay.
comment:4 in reply to: ↑ 3 Changed 2 years ago by rickmastfan67
Replying to boman:
I think, the patch is ready until the weekend.
I was slightly thrown out of schedule.
I'm sorry for not letting you know about the delay.
Hey man, it's all cool. Real life is more important anyways. ;) There is no rush on this anyways since it's just an enhancement. ;) Anyways, I still appreciate you taking on this challenge as I can't code my way out of a paper bag unless it's a copy and paste and changing one word kind of tweak, haha.
comment:5 Changed 2 years ago by rickmastfan67
boman, I see that you have posted the update for the plugin! Looks good except for one minor bug that I noticed. The clock on the top right doesn't show the correct time for the 12PM (Noon) to 1PM time slot. It says it's "12:15 AM" instead of "12:15 PM" when you hover the mouse in that time slot. It's happening on all days in the "12:00PM - 12:45PM" range.
Other than that small bug, it looks good. ;) Thanks again!
comment:6 Changed 2 years ago by rickmastfan67
boman, just downloaded the updated file and that bug no longer exists. :) Thanks again!
I'll leave you the honor of closing this. :)
comment:7 Changed 2 years ago by boman
- Resolution set to fixed
- Status changed from assigned to closed
"Choose key" screen