Opened 2 years ago
Last modified 18 months ago
#6102 new defect
Non-Connected way checks in validator needs to be projection independent
| Reported by: | Nakor | Owned by: | |
|---|---|---|---|
| Priority: | major | Component: | Core validator |
| Version: | latest | Keywords: | unconnected_way |
| Cc: |
Description (last modified by simon04)
If you run validator the attached file in 3782 it correctly detects "Way end node near other highway".
In 3976 it does not detect it.
Attachments (2)
Change History (17)
Changed 2 years ago by Nakor
comment:1 Changed 2 years ago by skyper
- Component changed from Core to Core validator
comment:2 Changed 2 years ago by skyper
comment:3 Changed 2 years ago by skyper
strange just some minutes ago it worked for some ways but now it does not.
comment:4 Changed 2 years ago by Zibik
Hello
I have the same problem with validator...
comment:5 Changed 2 years ago by Nakor
- Summary changed from Validator won't detect non connected highways to Validator won't detect non connected highways anymore
3921 is OK
3925 has the bug
comment:6 Changed 2 years ago by stoecker
NOTE: Error due to scaling factor change for mercator code?
comment:7 Changed 2 years ago by Nakor
I tried to narrow it down to a precise revision:
- 3921 works fine
- 3922 is broken
comment:8 Changed 2 years ago by Nakor
- Owner changed from team to Nakor
- Status changed from new to assigned
- Summary changed from Validator won't detect non connected highways anymore to [patch] Validator won't detect non connected highways anymore
@stoecker this is the reason. Attached is a patch that fixes the issue
comment:9 Changed 2 years ago by Nakor
- Summary changed from [patch] Validator won't detect non connected highways anymore to [incomplete patch] Validator won't detect non connected highways anymore
There is something more. The patch works on small examples but get stuck on big files.
comment:10 Changed 2 years ago by stoecker
In [4034/josm]:
comment:11 Changed 2 years ago by stoecker
The code depends on display projection. This is not really usable. It either should rely on direct LatLon calculations (e.g. greatCircleDistance() or force e.g. mercator projection for calculations.
comment:12 Changed 2 years ago by stoecker
- Summary changed from [incomplete patch] Validator won't detect non connected highways anymore to Non-Connected way checks in validator needs to be projection independent
comment:13 Changed 2 years ago by Nakor
- Owner Nakor deleted
- Status changed from assigned to new
comment:14 Changed 18 months ago by simon04
- Description modified (diff)
- Keywords UnconnectedWays added
comment:15 Changed 18 months ago by simon04
- Keywords unconnected_way added; UnconnectedWays removed
In r3992 it does not find any "way end node near other way" anymore.