Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6100 closed enhancement (fixed)

[PATCH] add HikeBikeMap and ÖPNV-Karte to Jmapviewer d/l dialog

Reported by: cmuelle8 Owned by: team
Priority: normal Component: Core
Version: latest Keywords: jmapviewer oepnvkarte hikebike
Cc:

Description

nur ein paar Details, die einem Mapper das Leben vereinfachen..

Gruß,
cmuelle8

Attachments (1)

jmapviewer.alternative.sources.patch (2.6 KB) - added by cmuelle8 2 years ago.
add some more common tile sources to the builtin jmapviewer d/l dialog

Download all attachments as: .zip

Change History (7)

Changed 2 years ago by cmuelle8

add some more common tile sources to the builtin jmapviewer d/l dialog

comment:1 Changed 2 years ago by stoecker

The Ö in ÖPNV should be coded using \u....

comment:2 Changed 2 years ago by bastiK

Any tms imagery source that the user has selected will show up in the jmapviewer, so shouldn't we rather put it on http://josm.openstreetmap.de/wiki/Maps (default=true)? That way the user can get rid of these entries if they want to (for whatever reason).

comment:3 Changed 2 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

Added, but not as default, as they are not worldwide.

comment:4 follow-up: Changed 2 years ago by cmuelle8

I have not checked your new commit yet, but it seems JMapViewer is used at two places

1) as TMS-LayerBackground
2) in the Data-Download-View obtainable by Strg+D

My workflow, when fixing things, is

A) to first browse the rendered map in the Data-Download-View
B) then select the area, hit download - the following steps of my workflow don't necessarily need the TMS-Layer anymore (I often just use it in the Download-Dialog to find errors)

To me it seemed, that the TMSs available in the Download-View were not configurable by the TMS/WMS Tab in Prefs - this is why I orginally patched the code. Maybe the Download-View should be synchronized then to the TMSs the user set active on TMS/WMS Tab in Prefs!?



Greetings

comment:5 in reply to: ↑ 4 ; follow-up: Changed 2 years ago by bastiK

Replying to cmuelle8:

I have not checked your new commit yet, but it seems JMapViewer is used at two places

1) as TMS-LayerBackground
2) in the Data-Download-View obtainable by Strg+D

My workflow, when fixing things, is

A) to first browse the rendered map in the Data-Download-View
B) then select the area, hit download - the following steps of my workflow don't necessarily need the TMS-Layer anymore (I often just use it in the Download-Dialog to find errors)

To me it seemed, that the TMSs available in the Download-View were not configurable by the TMS/WMS Tab in Prefs - this is why I orginally patched the code. Maybe the Download-View should be synchronized then to the TMSs the user set active on TMS/WMS Tab in Prefs!?

It works already like that, see above comment.

comment:6 in reply to: ↑ 5 Changed 2 years ago by cmuelle8

Replying to bastiK:

Replying to cmuelle8:

Oh, ok sorry for bothering, somehow I did not receive the comment by mail or it passed by unnoticed.. Thanks for the quick adoption. Have a nice weekend (if that's possible after japan news..), Christian

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.