Missing attribution for OSM

[kellerma]

When displaying a map from the OpenStreetMap the attribution should be displayed properly:
a) the licence (CC-by-SA)
b) the origin (OpenStreetMap)

I know that at the moment there's "OpenStreetMap wechselt die Lizenz. Dazu ist die <etc.>" at the splash screen but that's only a "temporary" "solution".

It would be better to show attribution within the "slippy map chooser". Couldn't find a way
to open a ticket for "jmapviewer" which has the same defect.

Thank you.

[anonymous]

The JMapViewer already provides attribution information for all Tile Sources. It's just not shown in JOSM.

[mfloryan]

Patch with new functionality

[mfloryan]

Indicated this ticket now has a patch.

[kellerma]

Mmmh, maybe I don't understand the patch but why should the attribution text be visible only for 10 s and not as long as the slippy map chooser is active?
When we choose "Bing" within the slippy map chooser the attribution doesn't vanish after 10 seconds.

As a side-note: The "Background Terms of Use" are not "clickable" in the "Bing view".

[kellerma]

The JMapViewer already provides attribution information for all Tile Sources

@anonymous
You're correct, it has been added by Upliner two months ago.

Still if someone likes to add attribution to the "demo-app" JMapViewer_Demo.jar, also.

[mfloryan]

Replying to kellerma:

Mmmh, maybe I don't understand the patch but why should the attribution text be visible only for 10 s and not as long as the slippy map chooser is active?

I added an overlay that shows the attribution text but wasn't sure if it wouldn't be too obtrusive if it stayed fixed.
The patch is for JOSM as I wasn't sure how to submit a patch for JMapViewer but now looking at the code it would be a better place to submit it.

When we choose "Bing" within the slippy map chooser the attribution doesn't vanish after 10 seconds.

True, but that's rendered right on the map. I guess it should equally be rendered on the other maps.

As a side-note: The "Background Terms of Use" are not "clickable" in the "Bing view".

I guess it should be - again, it would need a fix for the JMapViewer. I can prepare one.

[mfloryan]

Replying to kellerma:

The JMapViewer already provides attribution information for all Tile Sources

@anonymous
You're correct, it has been added by Upliner two months ago.

Still if someone likes to add attribution to the "demo-app" JMapViewer_Demo.jar, also.

Yup, this can be done. I'll prepare a cumulative patch for JMapViewer and we can see how to get it applied. If the attribution is shown in the demo it will also be visible in JOSM.

[mfloryan]

Actually I realised that even the current attribution text in the JMapViewer source code for OSM is incorrect. Will fix that too.

[mfloryan]

Attribution patch for the JMapViewer - will submit to authors.

[mfloryan]

The patch has been applied and committed as #25314 in the OSM repository.

However, the link is still not click-able, this probably needs to be another piece of work at it might need a more significant change.

[glebius]

The patch applied to the SVN broke all TMS layers functionality:

​https://josm.openstreetmap.de/ticket/5965

I reverted it partially in OSM rev 25336.

[kellerma]

TMS works again but now attribution is also missing again

[Zverikk]

This was a bug in TMS Layer. As soon as #5965 is fixed, the patch can be reapplied.

[kellerma]

It seems that #5965 has been fixed so can you re-apply the "3-lines-only" of the remaining patch?

Thank you.

[bastiK]

Replying to kellerma:

It seems that #5965 has been fixed so can you re-apply the "3-lines-only" of the remaining patch?

Thank you.

what patch do you want applied and where?

[anonymous]

Replying to bastiK:

Replying to kellerma:

It seems that #5965 has been fixed so can you re-apply the "3-lines-only" of the remaining patch?

Thank you.

what patch do you want applied and where?

None. It's all sorted now so no more changes are needed. Attribution is now shown correctly.

[bastiK]

see #6075

[bastiK]

Doesn't work for me, I can see no attribution for Mapnik or other OSM layers.

[stoecker]

Works for SlippyMapChooser only currently. TMS layers are "hand-made" and thus have no attribution info. I will add this at the Maps page, so future users get the attribution (needs some server work for downwards compatibility before I can make the entries), but I have no idea how to fix this for the legacy entries.

NOTE: Slippymapchooser Mapnik/CycleMap and T@H aren't the same as TMS backgrounds. They get replaced internally for historic reasons.

[stoecker]

In [4198/josm]:

fix #5911 - silently add attribution information also to old entries, may take some restarts to be done everywhere

[stoecker]

NOTE: Refresh server maps list and probably one or two restarts and you should get attribution also for standard entries.