Filter entries are mixed up

[ch70]

When I leave the filter plugin with some entries active, close JOSM and start it again, it happens from time to time that the entries in the list are mixed up, i.e. some entries

1. are doubled,
2. are missing,
3. have been moved to a different position (usually the last entry is moved to a top position).

Apart from the last problem which seems to happen with every restart of JOSM, the other two don't occur every time (I don't see a pattern yet).

System details:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-01-07 02:31:05
Last Changed Author: framm
Revision: 3776
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-01-07 00:54:21 +0100 (Fri, 07 Jan 2011)
Last Changed Rev: 3776

Identification: JOSM/1.5 (3776 de)
Memory Usage: 185 MB / 448 MB (47 MB allocated, but free)
Java version: 1.6.0_22, Sun Microsystems Inc., Java HotSpot(TM) Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: DirectUpload (24239)
Plugin: FixAddresses (24942)
Plugin: RoadSigns (22850)
Plugin: alignways (24815)
Plugin: buildings_tools (23804)
Plugin: colorscheme (21563)
Plugin: contourmerge (24975)
Plugin: download_along (24986)
Plugin: editgpx (23659)
Plugin: graphview (23435)
Plugin: measurement (22547)
Plugin: openstreetbugs (23747)
Plugin: restart (24396)
Plugin: reverter (24887)
Plugin: tageditor (21026)
Plugin: tagging-preset-tester (22454)
Plugin: turnrestrictions (24937)
Plugin: utilsplugin2 (24792)
Plugin: waydownloader (21706)

[ch70]

There might be an explanation for (3): I have ten filters and they are sorted in the preferences file in following order:

filters.filter.0
filters.filter.1
filters.filter.10
filters.filter.2
filters.filter.3
filters.filter.4
filters.filter.5
filters.filter.6
filters.filter.7
filters.filter.8
filters.filter.9

And that's exactly the order that I get in the filter window: the last entry (no 10) showing up on the third position.

[stoecker]

Filters does not yet use proper Array prefs. The selfmade prefs are probably broken and should be replaced by proper Array preferences.

[bastiK]

In [3908/josm]:

new preference type (list of structs). Should be more flexible when preference options are added and dropped for a list like features. (Not sure how far we get with this key=value approach, maybe it's time for xml preferences.) Fixes #5850 - Filter entries are mixed up