Modify

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5726 closed defect (fixed)

adjust offset dialog does not make it clear that you can move layer with mouse

Reported by: anonymous Owned by: Upliner
Priority: normal Component: Core imagery
Version: latest Keywords:
Cc: osm@…

Description

two days ago i could adjust the bingimages offset with the a button on the left side.
this is a good place for this function, but now i couldn't find the new place or this button anymore

ok, i found the new offset-function, but this is a awful thing, absolutly ;-)

thx
Bernd

Attachments (0)

Change History (10)

comment:1 Changed 2 years ago by bastiK

Please explain in more detail why you think it was better before.

comment:2 Changed 2 years ago by berndw OSM-Bonn

It was better. to move the BING-Layer with the mouse, with the new function it is to difficult, to set the exact offset

comment:3 Changed 2 years ago by bastiK

  • Summary changed from please bring back the adjust button for imagery to adjust offset dialog does not make it clear that you can move layer with mouse

It is still possible to move the layer with the mouse while the adjust dialog is open. We will add a button or explanation text to make this more obvious.

comment:4 Changed 2 years ago by Upliner

Ticket #5733 has been marked as a duplicate of this ticket.

comment:5 Changed 2 years ago by malenki

  • Cc osm@… added

I agree with the OP that the function is implemented quite awfully. Especially after there has been a button for offsetting the layer which has been removed now.

comment:6 Changed 2 years ago by berndw OSM-Bonn

Ok, this function works if the dialog is open, but the it is not self-explanatory, i have tried to add some values ;-) manually.
The resulting values are not relevant for me, because they are not consistent. Can you add this to status line in the (main)window?

The Button should be on better visible position, possible with a short hint for new users
But this is only a wish from my side ;-)

thx
Bernd

comment:7 Changed 2 years ago by Upliner

Explaination was added in [3722/josm]. However, I'm not going to close this ticket for a while because I was asked to make possible to add the adjust button to the toolbar using Toolbar Custumization and to setup a shortcut for it.

comment:8 Changed 2 years ago by berndw OSM-Bonn

I got this, if i want to add the offset-button to the toolbar
only put this only the left in the config-window and tried to save by clicking ok

Bernd

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-12-17 02:31:34
Last Changed Author: bastiK
Revision: 3730
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-12-16 18:20:22 +0100 (Thu, 16 Dec 2010)
Last Changed Rev: 3730

Identification: JOSM/1.5 (3730 de)
Memory Usage: 413 MB / 1820 MB (110 MB allocated, but free)
Java version: 1.6.0_22, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: FixAddresses (24232)
Plugin: RoadSigns (22850)
Plugin: measurement (22547)
Plugin: openstreetbugs (23747)
Plugin: turnrestrictions (24125)

java.lang.NullPointerException

at org.openstreetmap.josm.gui.preferences.ToolbarPreferences$ActionParser.escape(ToolbarPreferences.java:172)
at org.openstreetmap.josm.gui.preferences.ToolbarPreferences$ActionParser.saveAction(ToolbarPreferences.java:187)
at org.openstreetmap.josm.gui.preferences.ToolbarPreferences$Settings.ok(ToolbarPreferences.java:652)
at org.openstreetmap.josm.gui.preferences.PreferenceTabbedPane$1.run(PreferenceTabbedPane.java:161)
at org.openstreetmap.josm.gui.preferences.PreferenceTabbedPane.savePreferences(PreferenceTabbedPane.java:210)
at org.openstreetmap.josm.gui.preferences.PreferenceDialog$OKAction.actionPerformed(PreferenceDialog.java:120)
at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
at java.awt.Component.processMouseEvent(Component.java:6267)
at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
at java.awt.Component.processEvent(Component.java:6032)
at java.awt.Container.processEvent(Container.java:2041)
at java.awt.Component.dispatchEventImpl(Component.java:4630)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4577)
at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
at java.awt.Container.dispatchEventImpl(Container.java:2085)
at java.awt.Window.dispatchEventImpl(Window.java:2478)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178)
at java.awt.Dialog$1.run(Dialog.java:1046)
at java.awt.Dialog$3.run(Dialog.java:1098)
at java.security.AccessController.doPrivileged(Native Method)
at java.awt.Dialog.show(Dialog.java:1096)
at java.awt.Component.show(Component.java:1563)
at java.awt.Component.setVisible(Component.java:1515)
at java.awt.Window.setVisible(Window.java:842)
at java.awt.Dialog.setVisible(Dialog.java:986)
at org.openstreetmap.josm.gui.preferences.PreferenceDialog.setVisible(PreferenceDialog.java:86)
at org.openstreetmap.josm.actions.PreferencesAction.run(PreferencesAction.java:38)
at org.openstreetmap.josm.actions.PreferencesAction.actionPerformed(PreferencesAction.java:34)
at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1633)
at javax.swing.JComponent.processKeyBinding(JComponent.java:2851)
at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:267)
at javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:229)
at javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2928)
at javax.swing.JComponent.processKeyBindings(JComponent.java:2920)
at javax.swing.JComponent.processKeyEvent(JComponent.java:2814)
at java.awt.Component.processEvent(Component.java:6044)
at java.awt.Container.processEvent(Container.java:2041)
at java.awt.Component.dispatchEventImpl(Component.java:4630)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1850)
at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:712)
at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:990)
at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:855)
at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:676)
at java.awt.Component.dispatchEventImpl(Component.java:4502)
at java.awt.Container.dispatchEventImpl(Container.java:2099)
at java.awt.Window.dispatchEventImpl(Window.java:2478)
at java.awt.Component.dispatchEvent(Component.java:4460)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

comment:9 Changed 2 years ago by Upliner

  • Resolution set to fixed
  • Status changed from new to closed

In [3737/josm]:

make possible to place imagery offset action to the top toolbar and place it there by default; completely fixes #5726

comment:10 Changed 2 years ago by Upliner

Also, if you still like WMSPlugin-style adjust tool, you can use plugin "imageryadjust"

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.