Opened 2 years ago
Closed 21 months ago
#5706 closed defect (fixed)
[Patch needs rework] Role Verification Warnings
| Reported by: | rickmastfan67 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core |
| Version: | latest | Keywords: | Role Verification; validator |
| Cc: |
Description
This has been around for awhile, but the Validation Plugin (and even now when it's been merged into JOSM) has been throwing up a warning when you put any cardinal direction (north, south, east, west) into the role way of a relation.
Since the Validation Plugin is now part of JOSM, can we PLEASE get this verification bug eliminated?
If you haven't seen this happen before, just download the following relation (420779) as an example and run the Validation on it and you'll see it pop up the "north" and "south" role verification problem. That or just test the file I've attached where I've created an example using all four cardinal directions.
Attachments (3)
Change History (9)
Changed 2 years ago by rickmastfan67
Changed 21 months ago by simon04
Changed 21 months ago by simon04
same as attachment:5706.patch, but ignoring whitespace for easier reviewing
comment:1 Changed 21 months ago by simon04
- Summary changed from Role Verification Warnings to [Patch] Role Verification Warnings
Patch attached. In order to group similar roles, allowed comma separated values in roles/role/@key in defaultpresets.xml. Please check for any bad side effects.
comment:2 follow-up: ↓ 3 Changed 21 months ago by stoecker
- Summary changed from [Patch] Role Verification Warnings to [Patch needs rework] Role Verification Warnings
The comma separation will break TaggingPresets.
I don't like these direction roles much. Probably we can add a new preset "Directional Route (America)" which has these tags.
comment:3 in reply to: ↑ 2 Changed 21 months ago by rickmastfan67
Replying to stoecker:
The comma separation will break TaggingPresets.
I don't like these direction roles much. Probably we can add a new preset "Directional Route (America)" which has these tags.
I would call it "Directional Route (North America)" since Canada uses the same roles as the USA. So does Mexico as far as I know.
comment:4 follow-up: ↓ 5 Changed 21 months ago by stoecker
Well, Canada and Mexiko are in North America or am I wrong?
comment:5 in reply to: ↑ 4 Changed 21 months ago by rickmastfan67
Replying to stoecker:
Well, Canada and Mexiko are in North America or am I wrong?
Well, you just said "America" and there are two continents that have "America" in the name. ;) hehe
To be honest, I have no idea how South America does there highways, hence the "Directional Route (North America)" suggestion. ;)
comment:6 Changed 21 months ago by stoecker
- Resolution set to fixed
- Status changed from new to closed
In [4367/josm]:
Shows example of all four cardinal directions throwing up Warnings.