#5646 closed enhancement (fixed)
[patch] Additional Gas Station Brand Presets
| Reported by: | rickmastfan67 | Owned by: | christeck |
|---|---|---|---|
| Priority: | normal | Component: | Internal preset |
| Version: | latest | Keywords: | Gas Stations Brands |
| Cc: |
Description (last modified by rickmastfan67)
I was just looking at the presets for the Gas Station Brands inside of JOSM and I noticed a few missing that could be added for the USA (and Canadian) people. Here's a few stations that I recommend adding in the brand presets:
Chevron
Sunoco
Gulf
Exxon
Petro-Canada
Pioneer
Mobil
Citgo
Attachments (1)
Change History (10)
comment:1 Changed 3 years ago by rickmastfan67
- Description modified (diff)
Changed 3 years ago by rickmastfan67
comment:2 Changed 3 years ago by rickmastfan67
- Summary changed from Additional Gas Station Brand Presets to [patch] Additional Gas Station Brand Presets
comment:3 Changed 3 years ago by bastiK
- Resolution set to fixed
- Status changed from new to closed
In [3667/josm]:
comment:4 Changed 3 years ago by rickmastfan67
- Resolution fixed deleted
- Status changed from closed to reopened
bastiK, I was just looking @ the change log for when you applied the patch and I noticed something wrong. Somehow, the "A" for "Agip" got deleted when you applied the patch. It was in my patch that I attached. Don't know how that got messed up when you applied it. Must have been a simple typo.
If you look at the change log (3667) you linked to in your post above, you can see the problem. It's the first entry after "values=".
comment:5 Changed 3 years ago by bastiK
Thanks, fixed in [3668]. Did Copy&Paste because patch did not apply for some reason...
comment:6 Changed 3 years ago by rickmastfan67
Replying to bastiK:
Thanks, fixed in [3668]. Did Copy&Paste because patch did not apply for some reason...
Well, as I said in comment #2, this was the first time I've ever done something like this, so I was bound to make some mistake on making the patch. Made it in Notepad++. lol. Guess looking @ somebody's else patch to learn how to do it didn't fully work right. hehe.
comment:7 Changed 3 years ago by rickmastfan67
- Resolution set to fixed
- Status changed from reopened to closed
comment:8 Changed 2 years ago by pl71
Is there a chance additional country-specific brands (even with different char sets) to be included?
comment:9 Changed 2 years ago by stoecker
You can create your own preset.



I've just created a patch for this. My first attempt at anything like this. So, please let me know if I've done it correctly.