Modify

Opened 3 years ago

Last modified 17 months ago

#5638 new defect

Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor

Reported by: rickmastfan67 Owned by: team
Priority: major Component: Core
Version: latest Keywords:
Cc:

Description

I have several plugins for JOSM installed here on my copy encase I ever need to use them. Because of that, the ones that are installed in the "Tools" menu make that menu too long to fully display on my monitor (1680x1050). Because of that, I can't select some that are in the menu, but below the bottom of my monitor, unless I know the shortcut for the tool (if it has one). (Yes, I know how to add items to my toolbar, but I don't use them that often to justify it.) Can there be a way to setup and allow the menu to spawn a second list right beside it if all the items in "Tools" can't be shown? Or how about make the icons smaller in that menu to allow more stuff to be shown (like in the Presets menu)? I know this would be more of a problem for people using a Laptop because of the limited space their screens have compared to my desktop. Just thought I would throw this out there. If you consider this a "enhancement", please go ahead and change the type of this report.

Attachments (3)

Screenshot-long-Tools-menu.png (44.8 KB) - added by bastiK 2 years ago.
example for a long tools menu when some plugins are installed
5638.patch (22.5 KB) - added by simon04 20 months ago.
Screenshot800x600.png (104.3 KB) - added by akks 18 months ago.

Download all attachments as: .zip

Change History (34)

Changed 2 years ago by bastiK

example for a long tools menu when some plugins are installed

comment:1 Changed 2 years ago by bastiK

example:

example for a long tools menu when some plugins are installed

comment:2 Changed 2 years ago by stoecker

One step would be to remove the separations in the plugins. They only waste space.

comment:3 Changed 2 years ago by stoecker

In [3678/josm]:

move info and history from tools to view menu - see #5638

comment:4 Changed 2 years ago by bastiK

Ticket #5158 has been marked as a duplicate of this ticket.

comment:5 Changed 23 months ago by stoecker

Ticket #6531 has been marked as a duplicate of this ticket.

comment:6 Changed 21 months ago by simon04

http://tips4java.wordpress.com/2009/02/01/menu-scroller/ looks promising. However, the licence is unclear.

comment:7 Changed 21 months ago by stoecker

The left handside toolbar has similar functionality already.

comment:8 Changed 21 months ago by simon04

Ticket #5612 has been marked as a duplicate of this ticket.

comment:9 Changed 21 months ago by bastiK

Replying to simon04:

http://tips4java.wordpress.com/2009/02/01/menu-scroller/ looks promising. However, the licence is unclear.

I like it, license shouldn't be a problem:

You are free to use and/or modify any or all code posted on the Java Tips Weblog without restriction. A credit in the code comments would be nice, but not in any way mandatory.

(http://tips4java.wordpress.com/about/)

Replying to stoecker:

The left handside toolbar has similar functionality already.

Yes, we have ScrollViewport class, but apart from the timer, there is not much similarity.

comment:10 Changed 21 months ago by skyper

I also have the problem with long preset list.

comment:11 Changed 20 months ago by simon04

Ticket #6862 has been marked as a duplicate of this ticket.

Changed 20 months ago by simon04

comment:12 Changed 20 months ago by simon04

  • Summary changed from Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor to [Patch] Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor

I attempted to integrate MenuScroller, see the attached patch.

Currently, the number of items which are displayed at once is naïvely calculated by [screen height] / [height of New Layer]. Apart from that, MenuScroller seems to be working nicely.

comment:13 Changed 20 months ago by simon04

Ticket #6019 has been marked as a duplicate of this ticket.

Version 0, edited 20 months ago by simon04 (next)

comment:14 follow-up: Changed 20 months ago by bastiK

There is a problem with the lower arrow button: It moves up and down, depending on the total height of the menu items.

The number of menu items is fixed. There are thin separators and larger items with an icon, so the total height varies, when there are more or less separators in the current view.

The whole approach to specify the number of menu items does not work when the items have different height. It should rather limit the total height of the scrolling menu section.

Anyway, the current patch is certainly an improvement of the current state.

comment:15 in reply to: ↑ 14 ; follow-up: Changed 20 months ago by simon04

Replying to bastiK:

It should rather limit the total height of the scrolling menu section.

That shouldn't be too hard to implement – I'll take a look at it.

comment:16 Changed 20 months ago by simon04

Ticket #6867 has been marked as a duplicate of this ticket.

comment:17 Changed 20 months ago by simon04

Using the screen height might be a problem when using multiple screens …

comment:18 in reply to: ↑ 15 ; follow-up: Changed 20 months ago by simon04

It should rather limit the total height of the scrolling menu section.

That shouldn't be too hard to implement – I'll take a look at it.

The change is harder than expected as scrollCount is used in several methods. I didn't want to rework all of them at the moment.

For now, we could add the current implementation and refine it afterwards?

comment:19 in reply to: ↑ 18 Changed 20 months ago by bastiK

Replying to simon04:

It should rather limit the total height of the scrolling menu section.

That shouldn't be too hard to implement – I'll take a look at it.

The change is harder than expected as scrollCount is used in several methods. I didn't want to rework all of them at the moment.

Why not comment out or remove the unused methods?

For now, we could add the current implementation and refine it afterwards?

Sure.

comment:20 Changed 20 months ago by bastiK

See #6925 for a context menu, where this could be used.

comment:21 Changed 20 months ago by bastiK

Ticket #6925 has been marked as a duplicate of this ticket.

comment:22 Changed 20 months ago by bastiK

What's the status?

comment:23 Changed 20 months ago by simon04

As the stable version was released, I suggest that I commit my patch from above. Some drawbacks already have been discussed.

comment:24 Changed 19 months ago by stoecker

Do you commit yourself?

comment:25 Changed 19 months ago by stoecker

What is the status?

comment:26 Changed 18 months ago by simon04

In [4593/josm]:

see #5638 - scroll long menus (thanks to tips4java.wordpress.com)


Sorry for not replying for a long time, I'm quite busy atm.

Let's test it. :-)

Last edited 18 months ago by simon04 (previous) (diff)

comment:27 Changed 18 months ago by akks

It seems to work OK on 800x600, only small feature would be better to improve:

often menu expands one line more then needed (not only for last item):


Changed 18 months ago by akks

comment:28 Changed 18 months ago by stoecker

  • Summary changed from [Patch] Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor to Too many plugins installed, thus they aren't visable in "Tools" because list is too long for the monitor

comment:29 Changed 18 months ago by simon04

Ticket #6554 has been marked as a duplicate of this ticket.

comment:30 Changed 17 months ago by akks

It works almost perfectly, so maybe someone should close the ticket?

comment:31 Changed 17 months ago by bastiK

There are still some quirks.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team. Next status will be 'new'.
Next status will be 'needinfo'.The owner will change to rickmastfan67
as duplicate The resolution will be set to duplicate. Next status will be 'closed'.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous. Next status will be 'assigned'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.