Modify

Opened 3 years ago

Closed 3 years ago

#5470 closed defect (fixed)

fullscreen moves dialogs below main window

Reported by: bastiK Owned by: team
Priority: normal Component: Core
Version: Keywords:
Cc:

Description

If you have detached toggle dialogs or relation dialog open and enter fullscreen mode (F11) the dialogs are no longer visible.

(However you can toggle again to bring them to the front. All new dialogs are shown normally.)

Even when exiting fullscreen mode, this stays the same.

Both for exclusive & non-exclusive fullscreen mode on gnome/linux.

Attachments (2)

FullscreenToggleAction.java.patch (3.3 KB) - added by anonymous 3 years ago.
minor reorganizing for better "code looks"
FullscreenToggleAction.java.2.patch (3.3 KB) - added by Christian Müller <cmuelle8> 3 years ago.
prevBounds assignment was erroneously missing in the last patch..

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by anonymous

I cannot reproduce the problem in windows xp (neither with the toggle dialogs nor with a relation dialog open - they all open up in front of the main window and also stay there if i refocus the main window) - are you sure it happens on non-exclusive mode under linux? A guess could be that the window manager automatically sets the main window of josm to AlwaysOnTop when java requests for fullscreen..

greetings

comment:2 Changed 3 years ago by bastiK

Yes, it does not matter if i use exclusive or non-exclusive mode. The only difference i notice: Using non-exclusive mode, it does not restore the window geometry when i return from fullscreen (which is a bug, i suppose).

Note that it is no problem to open a dialog when I'm already in fullscreen mode. They open normally and stay on top if i refocus main window. The problem is the process of switching to fullscreen or from fullscreen to normal view.

Each time I press F11 all dialog windows vanish. They are not hidden behind the main window, they are just gone. I suppose it has something to do with the frame getting disposed.

comment:3 Changed 3 years ago by bastiK

  • Resolution set to fixed
  • Status changed from new to closed

(In [3543]) fixed #5470 - fullscreen moves dialogs below main window

comment:4 follow-up: Changed 3 years ago by bastiK

Not sure if this is the best solution, but it works. :)

Changed 3 years ago by anonymous

minor reorganizing for better "code looks"

Changed 3 years ago by Christian Müller <cmuelle8>

prevBounds assignment was erroneously missing in the last patch..

comment:5 in reply to: ↑ 4 Changed 3 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to bastiK:

Not sure if this is the best solution, but it works. :)

yep, it does in Windows as well. thanks for taking the unixoid steps.. i've just done some cosmetics, so the code is slicker for the next generation to read, if they do so :)

comment:6 Changed 3 years ago by bastiK

(In [3551]) see #5470 (patch by Christian Müller) - cosmetics for FullscreenToggleAction

comment:7 Changed 3 years ago by bastiK

  • Resolution set to fixed
  • Status changed from reopened to closed

It's not quite what you suggested, but similar.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.