[patch] get rid of window decorations in fullscreen mode

[cmuelle8]

this patch is especially helpful if you want to use josm on a netbook to have more screen real estate

tested with Windows XP, but the code is pure java / platform independent..

the previous behavior when going to fullscreen was identical to using the maximize button (from a user perspective)

have a nice day,
christian

[cmuelle8]

have fullscreen mode use the full screen

[bastiK]

(In [3535]) applied #5463 (patch by Christian Müller) - get rid of window decorations in fullscreen mode

[cmuelle8]

Replying to bastiK:

(In [3535]) applied #5463 (patch by Christian Müller) - get rid of window decorations in fullscreen mode

thanks for adding this so quick. unfortunately there is a problem, i just discovered. when popups open, josm gets minimized. this is a very obscure behavior - i don't know if it is just a windows xp problem or if it happens on unix as well, but in it's current form, some code is still missing to have it work nicely..

however, if u click josm in the taskbar to restore the window, everything is as it should be (josm is fullscreen and the respective popup shows up front). sorry for the inconvenience.. do you have an idea, how to fix it? you can trigger the behavior by downloading data (the jmapviewer opens and the app minimizes..)..

greetings

[bastiK]

cannot reproduce the problem with ubuntu karmic

[bastiK]

Hi,

for MS Windows, it seems to be impossible to display a JDialog on top of the main frame if it is in full screen exclusive mode.

​http://stackoverflow.com/questions/1722922/jdialog-not-displaying-when-in-fullscreen-mode

However a "light" version of fullscreen is supposed to work:

        Frame frame = (Frame)Main.parent;
        java.awt.Dimension dim = java.awt.Toolkit.getDefaultToolkit().getScreenSize();

        frame. setBounds(0,0,dim.width, dim.height);
        frame.dispose();
        frame.setUndecorated(true);
        frame.setResizable(false);
        frame.setVisible(true);

Can you test and prepare a patch?

[cmuelle8]

Replying to bastiK:

Hi,

for MS Windows, it seems to be impossible to display a JDialog on top of the main frame if it is in full screen exclusive mode.

yeah, it is.. the only way would be using internalframes with a jdesktoppane or jlayeredpane (the java solution to not create new (OS based) windows)..

if the window is undecorated it gets the whole screen by default, so the patch is simple - but you don't get the exclusive, accelerated mode (ok, in windowed mode I don't have this either, so I guess it's fine..)

[cmuelle8]

use non-exclusive fullscreen mode in windows per default..

[cmuelle8]

ps: tested and works on my side (Windows XP)..

somebody with Vista or 7 should test it as well - maybe bounds or other stuff is needed there..

[bastiK]

The bounds stuff is needed when you use simulated (non-exclusive) mode on gnome/linux.

[bastiK]

(In [3537]) fix fullscreen by adding simulated mode for windows platorm (patch by Christian Müller) - see #5463 - get rid of window decorations in fullscreen mode

[bastiK]

See #5470 for an issue i have with fullscreen.

[anonymous]

i'll close this one and attach some cosmetic changes to #5470 ..

so the fullscreen issue are more or less solved (of course someone may also port whole of josm to use JDesktopPane or the docking frames framework to use that nitty exclusive mode on windows also, but what's the real gain? :-) )