Modify

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#5380 closed defect (duplicate)

multipolygon plugin sets shortcut to "m"

Reported by: dieterdreist Owned by: bilbo
Priority: major Component: Plugin multipoly
Version: latest Keywords: shortcut
Cc:

Description

multipolygon plugin sets shortcut to "m". This results in change for shortcut merge nodes.

Attachments (0)

Change History (11)

comment:1 in reply to: ↑ description Changed 3 years ago by dieterdreist

Replying to dieterdreist:

multipolygon plugin sets shortcut to "m". This results in change for shortcut merge nodes.

Delete went from d to e (because of create multipolygon which is now on d). Please revert as well.

comment:2 Changed 3 years ago by bilbo

Shortcuts are settable in preferences - currently the shortcut is:
KeyEvent.VK_M, Shortcut.GROUP_EDIT, Shortcut.SHIFT_DEFAULT

Which should be usually Alt+shift+m, though some other plugins (like measurement plugin) likes to steal thet combination, but I never saw the plugin to falling back to only "M".

If "m" gets somehow assigned to multipoly, you can fix it in your preferences, in the keyboard shortcut section. I can't do anything to fix it in the plugin code.

comment:3 Changed 3 years ago by bilbo

  • Resolution set to worksforme
  • Status changed from new to closed

Try setting the keys in preferences. If you find impossible to set the keys in preferences to match yuour desired keys, please open another bug.

comment:4 Changed 3 years ago by bastiK

  • Resolution worksforme deleted
  • Status changed from closed to reopened

This is because multipoly-convert plugin has the same shortcut and JOSM's shortcut collision handling is a little strange...

comment:5 follow-up: Changed 3 years ago by bilbo

  • Component changed from Plugin multipoly to Core
  • Owner changed from bilbo to team
  • Status changed from reopened to new

But then this is not problem in multipoly plugin but in JOSM shortcut handling system.

comment:6 in reply to: ↑ 5 Changed 3 years ago by dieterdreist

Replying to bilbo:

But then this is not problem in multipoly plugin but in JOSM shortcut handling system.

It is both IMHO: Plugin-Developers shouldn't use already in use shortcuts for new functions, and the shortcut-handling-system should first assign core-shortcuts and after that those for plugins (and not allow to reassign shortcuts automatically by plugins that are already assigned to core functions, but only manually).

comment:7 follow-up: Changed 2 years ago by stoecker

  • Component changed from Core to Plugin multipoly
  • Owner changed from team to bilbo

comment:8 in reply to: ↑ 7 ; follow-up: Changed 2 years ago by skyper

Replying to stoecker:

Has core been fixed to not automatically override shortcuts from core ?

Otherwise we should open another ticket to not forget about the issue.

comment:9 in reply to: ↑ 8 Changed 2 years ago by skyper

Replying to skyper:

Replying to stoecker:

Has core been fixed to not automatically override shortcuts from core ?

Has not.

Otherwise we should open another ticket to not forget about the issue.

#6341

comment:10 Changed 2 years ago by skyper

  • Resolution set to duplicate
  • Status changed from new to closed

comment:11 Changed 2 years ago by skyper

Closed as duplicate of #5216.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.