Modify ↓

Ticket #5276 (closed defect: fixed)

Opened 19 months ago

Last modified 19 months ago

[PATCH] Preset/Icon for man_made=flagpole

Reported by: jcollie Owned by: christeck
Priority: normal Component: Internal preset
Version: Keywords:
Cc:

Description

Here's a patch and icon for man_made=flagpole

Attachments

flagpole.diff Download (1.6 KB) - added by jcollie 19 months ago.
patch
flagpole.png Download (457 bytes) - added by jcollie 19 months ago.
icon

Change History

Changed 19 months ago by jcollie

patch

Changed 19 months ago by jcollie

icon

comment:1 Changed 19 months ago by bastiK

  • Owner changed from team to christeck
  • Component changed from Core to Internal preset
  • Summary changed from Preset/Icon for man_made=flagpole to [PATCH] Preset/Icon for man_made=flagpole

comment:2 Changed 19 months ago by ce

  • Status changed from new to closed
  • Resolution set to fixed

(In [3391]) fixes #5276 Current build is broken so I cannot test whether the preset tags the elements correctly and whether the nodes are shown in the viewport with the correct icon. I assume yes for both.

comment:3 Changed 19 months ago by bastiK

  • Status changed from closed to reopened
  • Resolution fixed deleted

Does not work.

Build is not broken, JOSM source is in Java 6, now.

comment:4 Changed 19 months ago by jcollie

Is there a reason that the key was changed to man_made=flagpost? As far as I can tell man_made=flagpost is not used whereas man_made=flagpole has 89 uses. Also why was the icon I provided not used? The "presets/flag.png" is a 32x32 icon which is larger than the 16x16 icons generally used on the map.

comment:5 Changed 19 months ago by ce

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [3395]) preset icon cut to 32x32. added mapstyle icon 16x16. adjusted elemstyles accordingly. fixes #5276

comment:6 Changed 19 months ago by bastiK

Why is this icon so big (32x32)? Normally mappaint icons are smaller.

comment:7 Changed 19 months ago by bastiK

  • Status changed from closed to reopened
  • Resolution fixed deleted

see above

comment:8 Changed 19 months ago by christeck

The tag is set correctly now, the mappaint icon has been separated by the presets icon and shows up at a size of 16px as mappaint icons sould do.

May I ask which problem still persists?

comment:9 Changed 19 months ago by bastiK

  • Status changed from reopened to closed
  • Resolution set to fixed

Sorry, it's alright. I guess I had an old version in my local svn when I tested it...

View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.