OSB

[RafalR <rrudzik@…>]

doubleclick on the bugs list (nothing has been loaded)

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-07-24 01:32:01
Last Changed Author: jttt
Revision: 3382
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-07-23 21:27:18 +0200 (Fri, 23 Jul 2010)
Last Changed Rev: 3382

Identification: JOSM/1.5 (3382 pl)
Memory Usage: 989 MB / 989 MB (936 MB allocated, but free)
Java version: 1.6.0_20, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows Vista
Dataset consistency test: No problems found

Plugin: DirectUpload (22017)
Plugin: PicLayer (21706)
Plugin: RoadSigns (22423)
Plugin: openstreetbugs (21706)
Plugin: remotecontrol (21706)
Plugin: turnrestrictions (21706)
Plugin: validator (22204)
Plugin: wmsplugin (22286)

java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.osb.gui.OsbDialog.zoomToNode(OsbDialog.java:305)
	at org.openstreetmap.josm.plugins.osb.gui.OsbDialog.mouseClicked(OsbDialog.java:310)
	at java.awt.AWTEventMulticaster.mouseClicked(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[hampelratte <henrik.niehaus@…>]

I can reproduce the error and I have fixed it already. The SVN server does not respond, though. So it might take some time till the changes apply.

[hampelratte <henrik.niehaus@…>]

Status: code checked in, plugin updated. New version should be available soon. Please close this ticket, if it works for you, too.

[RafalR <rrudzik@…>]

OsbDialog.java

308	    public void mouseClicked(MouseEvent e) {
309	        if (e.getButton() == MouseEvent.BUTTON1 && e.getClickCount() == 2) {
310	            Node selectedNode = getSelectedNode();
311	            if(selectedNode != null) { 
312	                zoomToNode(selectedNode);
313	            }
314	        }
315	    }

this still dont work correctly (22434)

[hampelratte <henrik.niehaus@…>]

Replying to RafalR <rrudzik@…>:

this still dont work correctly (22434)

You could please describe what does not work correctly? Any exception? Wrong behaviour?

[RafalR <rrudzik@…>]

function zoomToNode is called even if nothing is selected (before the data is loaded from OSB)

[hampelratte <henrik.niehaus@…>]

After spending some time playing around with different settings, I cannot trigger a method call of zoomToNode without having a node selected in the list. Furthermore zoomToNode is only called from mouseClicked, where I added the check for null. So in my opinion, it should be ok.

Could you please describe the steps you take, to produce the error? Is osb initially online / offline? Is data loaded before activating osb etc.

[RafalR <rrudzik@…>]

OK, dubleclick problem fixed, now is problem with right mouse click.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-07-17 01:31:31
Last Changed Author: bastiK
Revision: 3376
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-07-16 23:44:00 +0200 (Fri, 16 Jul 2010)
Last Changed Rev: 3376

Identification: JOSM/1.5 (3376 pl)
Memory Usage: 46 MB / 494 MB (25 MB allocated, but free)
Java version: 1.6.0_20, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows Vista
Dataset consistency test: No problems found

Plugin: openstreetbugs (22434)
Plugin: remotecontrol (21706)
Plugin: validator (22445)
Plugin: wmsplugin (22286)

java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.osb.gui.action.PopupFactory.createPopup(PopupFactory.java:45)
	at org.openstreetmap.josm.plugins.osb.gui.OsbDialog.mayTriggerPopup(OsbDialog.java:329)
	at org.openstreetmap.josm.plugins.osb.gui.OsbDialog.mouseReleased(OsbDialog.java:322)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

[hampelratte <henrik.niehaus@…>]

Ok, fixed that NPE, too. New Version should be available soon.