Opened 3 years ago
Closed 22 months ago
#5257 closed enhancement (fixed)
[Patch] Automatic fix to Reversed water
| Reported by: | e2jk | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core validator |
| Version: | tested | Keywords: | |
| Cc: |
Description
A counter-clockwise closed way with natural=water will generate the following error:
Reversed water: land not on left side
The fix for this error is to reverse the direction of the way. Currently there is no proposed automatic fix, so you need to select all those errors and click on the "Reverse the direction of all selected ways" button.
I believe this could be automatically fixed.
JOSM 3376
Validator 22204
Attachments (1)
Change History (5)
comment:1 Changed 23 months ago by simon04
comment:2 Changed 23 months ago by simon04
Btw: In WronglyOrderedWays there was is a minor bug when determining the orientation of a way, i.e., being (anti)clockwise. The problem is that the pair (last node of way, first node of way) is not taken into account.
The patch fixes this issue and reorganizes some code (e.g., provides Geometry.isClockwise(Way)).
Changed 23 months ago by simon04
comment:3 Changed 23 months ago by Casiope
- Summary changed from Automatic fix to Reversed water to [Patch] Automatic fix to Reversed water
comment:4 Changed 22 months ago by stoecker
- Resolution set to fixed
- Status changed from new to closed
In [4344/josm]:
According to the wiki (http://wiki.openstreetmap.org/wiki/Tag:natural=water), the orientation of natural=water does not matter. So remove testing natural=water?