Opened 3 years ago
Closed 20 months ago
#5216 closed enhancement (needinfo)
[patch needs rework] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension)
| Reported by: | dieterdreist | Owned by: | bilbo |
|---|---|---|---|
| Priority: | normal | Component: | Plugin multipoly |
| Version: | latest | Keywords: | shortcut mirror |
| Cc: |
Description
Strangely someone must have decided to change the shortcut for add node. I has become ALT+SHIFT+A instead of A. This is horrible. You have to change all the time when editing. Please don't change the mostly used shortcuts. IMHO this is a big usability fail.
Attachments (1)
Change History (13)
comment:1 in reply to: ↑ description Changed 3 years ago by dieterdreist
- Component changed from Core to Plugin
- Summary changed from shortcut for add nodes changed to shortcut for add nodes changed by "convert to multipolygon"-extension
comment:2 Changed 2 years ago by skyper
- Component changed from Plugin to Plugin multipoly
- Owner changed from team to bilbo
comment:3 Changed 2 years ago by skyper
Ticket #5380 has been marked as a duplicate of this ticket.
comment:4 Changed 2 years ago by skyper
- Keywords mirror added; add nodes removed
- Priority changed from major to normal
- Summary changed from shortcut for add nodes changed by "convert to multipolygon"-extension to shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension)
- Type changed from defect to enhancement
Now it conflicts with mirror but is silently moved.
comment:5 Changed 2 years ago by skyper
Ticket #6292 has been marked as a duplicate of this ticket.
comment:6 Changed 2 years ago by bilbo
Added patch that will fix the conflict - the default shortcut will be changed to Alt+M (it is not used by anything in default installation)
Note that all shortcuts can be redefined (actually, some of them like "copy" and "paste" can't, but this one can) in the settings.
Also, the patch updates the old comment in the source code so it will describe what the class does now, not what the class have done about year ago before people started improving it.
comment:7 Changed 2 years ago by bilbo
- Summary changed from shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) to [patch] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension)
comment:8 Changed 21 months ago by stoecker
- Owner changed from bilbo to dieterdreist
- Status changed from new to needinfo
- Summary changed from [patch] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) to [patch needs rework] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension)
Is this really necessary? I have no related shortcut conflict here. Also the Shortcut call should not directly use a KeyEvent-mask value.
comment:9 Changed 21 months ago by stoecker
- Owner changed from dieterdreist to bilbo
comment:10 Changed 21 months ago by dieterdreist
I am not sure what exactly the patch does. This ticket was changed several times by a lot of people. I don't have the original issue any more (that "add node" was not "a" for some time).
For your info, these are the current silent shortcut conflicts that I get, but I don't perceive them as problems:
Silent shortcut conflict: 'mapmode:parallel' moved by 'tools:pdfimport' to 'Alt+Umschalt+P'.
Silent shortcut conflict: 'subwindow:properties' moved by 'mapmode:parallel' to 'Alt+D'.
Silent shortcut conflict: 'properties:add' moved by 'menu:PicLayer' to 'Alt+G'.
Silent shortcut conflict: 'subwindow:authors' moved by 'tools:taggingresettester' to 'Alt+J'.
Keystroke alt pressed J is already assigned to utilsplugin2.ExtractPointAction@e9493a, will be overridden by org.openstreetmap.josm.gui.dialogs.ToggleDialog$ToggleDialogAction@1e2b67c
Silent shortcut conflict: 'subwindow:conflict' moved by 'menu:Public Transport' to 'Alt+Umschalt+C'.
I don't know how is the shortcut conflict handling, but preferably the shortcuts from the main module should not be overridden by plugins (or only on user confirmation). Maybe this is already the case.
comment:11 Changed 21 months ago by dieterdreist
- Owner changed from stoecker to bilbo
sorry, I got confused because I was marked as responsible for some seconds ;-), re-set bilbo.
comment:12 Changed 20 months ago by stoecker
- Resolution set to needinfo
- Status changed from needinfo to closed
Replying to dieterdreist:
:: This is caused by the "convert to multipolygon"-plugin-extension. Please change the default there!