JOSM build: fragile filtering of icons

[Gubaer]

When JOSM is built by the non-public nighly build script, "unused" icons are removed from the distribution. Probably the build script uses geticons.pl​.

This is a fragile concept because plugin authors rely on the icons in the JOSM repository too and because every missing icon triggers a fatal exception.

Eiter

• include all icon below images

or

• scan dependencies in the plugins managed on the OSM SVN too

[stoecker]

Build does not filter icons in main JOSM. It only filters icons used for the internal style. Everything else is still hand-made. The style-icons do not cause fatal errors when missing.

[stoecker]

P.S. The style subdirectory is out of control for josm, so this directory is not really usable for program code and must be filtered due to much unused stuff.

[Gubaer]

Not solved yet. A plugins still runs a in fatal exception if it loads an icon from the images/styles which is filtered out by the nighly build scripts. Again: the script which checks dependencies and silently drops images from the release, can and should check dependencies in the known plugins too.

[anonymous]

Everything in styles changes from time to time without any influence from josm development. Sometimes icons are rearranged there completely, moved or renamed. As already said this should not be used in JOSM code, only for icons which can be missing (like style).

It is a bug when style-icons are used in JOSM code.