Modify

Ticket #4687 (new defect)

Opened 2 years ago

Last modified 7 months ago

unsolvable conflict with nodes.

Reported by: skyper Owned by: team
Priority: normal Component: Core
Version: latest Keywords: unsolvable conflict node
Cc:

Description

I have several conflicts on nodes which are not solvable. All these conflicts are a deleted node visible on server on my side and not deleted and not visible on theirs.

I can take every combination out of the 4 but JOSM does nothing when I click on OK.

r3094, sun

I upload a osm. Just update data and try id: 259531960 or 259531957.

If it is not reproducable right away please try to solve the conflicts refering to ways by using their nodes, because I deleted some "lonely nodes" which had been left by solving element-conflict on ways.

Thanks skyper

Attachments

josm_bug_4687.osm.bz2 Download (116.7 KB) - added by skyper 2 years ago.
osm

Change History

Changed 2 years ago by skyper

osm

comment:1 Changed 2 years ago by jttt

Nothing happened because there was an exception that wasn't caught by BugReportExceptionHandler because it came from modal dialog. The exception should be shown since r3098 (thought it use undocumented behaviour and may work only on sun java).

Other thing is the eception. Unfortunatelly it works on my system, I don't get exception for listed nodes. But if you run josm without console, you may still find the exception in your ~/.xsession-errors file.

comment:2 Changed 2 years ago by skyper

  • Priority changed from critical to normal

It happened again. Sameway like the first time: I deleted a node while there was a conflict on it.

This time so the conflict somehow disapperead from the list (r3097).
Anyway the bug is not that grave, because you can solve all other conflicts, save and then "update data" again. Now you only get some conflicts and the one mentioned above are silently solved.

comment:3 Changed 2 years ago by jttt

Problem is that node has conflict in both visible and deleted state. If selected visible and deleted and end up with following exception:

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=259531960 version=2 MVD lat=47.97754963817524,lon=7.806038970102288}

at org.openstreetmap.josm.data.osm.OsmPrimitive.checkDataset(OsmPrimitive.java:167) at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:957) at org.openstreetmap.josm.command.DeletedStateConflictResolveCommand.fillModifiedData(DeletedStateConflictResolveCommand.java:89) at org.openstreetmap.josm.command.Command.executeCommand(Command.java:76) at org.openstreetmap.josm.command.DeletedStateConflictResolveCommand.executeCommand(DeletedStateConflictResolveCommand.java:58) at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:51) at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:38) at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:58) at org.openstreetmap.josm.gui.dialogs.ConflictResolutionDialog$ApplyResolutionAction.actionPerformed(ConflictResolutionDialog.java:266) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236) at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272) at java.awt.Component.processMouseEvent(Component.java:6263) at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) at java.awt.Component.processEvent(Component.java:6028) at java.awt.Container.processEvent(Container.java:2041) at java.awt.Component.dispatchEventImpl(Component.java:4630) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Component.dispatchEvent(Component.java:4460) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168) at java.awt.Container.dispatchEventImpl(Container.java:2085) at java.awt.Window.dispatchEventImpl(Window.java:2475) at java.awt.Component.dispatchEvent(Component.java:4460) at java.awt.EventQueue.dispatchEvent(EventQueue.java:599) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:178) at java.awt.Dialog$1.run(Dialog.java:1045) at java.awt.Dialog$3.run(Dialog.java:1097) at java.security.AccessController.doPrivileged(Native Method) at java.awt.Dialog.show(Dialog.java:1095) at java.awt.Component.show(Component.java:1563) at java.awt.Component.setVisible(Component.java:1515) at java.awt.Window.setVisible(Window.java:841) at java.awt.Dialog.setVisible(Dialog.java:985) at org.openstreetmap.josm.gui.dialogs.ConflictResolutionDialog.setVisible(ConflictResolutionDialog.java:117) at org.openstreetmap.josm.gui.dialogs.ConflictDialog.resolve(ConflictDialog.java:149) at org.openstreetmap.josm.gui.dialogs.ConflictDialog.access$1(ConflictDialog.java:138) at org.openstreetmap.josm.gui.dialogs.ConflictDialog$ResolveAction.actionPerformed(ConflictDialog.java:333) at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995) at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318) at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387) at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242) at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236) at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272) at java.awt.Component.processMouseEvent(Component.java:6263) at javax.swing.JComponent.processMouseEvent(JComponent.java:3267) at java.awt.Component.processEvent(Component.java:6028) at java.awt.Container.processEvent(Container.java:2041) at java.awt.Component.dispatchEventImpl(Component.java:4630) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Component.dispatchEvent(Component.java:4460) at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574) at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238) at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168) at java.awt.Container.dispatchEventImpl(Container.java:2085) at java.awt.Window.dispatchEventImpl(Window.java:2475) at java.awt.Component.dispatchEvent(Component.java:4460) at java.awt.EventQueue.dispatchEvent(EventQueue.java:599) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161) at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

comment:4 Changed 7 months ago by skyper

The problem with the nodes seems to be fixed,
but updating all data produces an error message for each bbox about "deleted node referenced: ...".
The message is only offered in the gui and a single line over five times the width of my screen and not selectable !

after clicking on OK (error message) + checking on server, I have a lot of relations with zero members but there exists members and you can download them, e.g. the relations should be indicated with "incomplete" but not with "0 Members".

r4202

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as new
as The resolution will be set. Next status will be 'closed'
to The owner will be changed from team. Next status will be 'new'
Next status will be 'needinfo'The owner will change to skyper
as duplicate The resolution will be set to duplicate. Next status will be 'closed'The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous. Next status will be 'assigned'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.