Modify

Opened 3 years ago

Closed 10 months ago

#4663 closed defect (fixed)

conflict manager: known elements from their's are named "incomplete"

Reported by: skyper Owned by: team
Priority: normal Component: Core
Version: latest Keywords: conflict manager element incomplete
Cc: skyper

Description (last modified by skyper)

I just "updated data" -> conflicts.

Trying to solve conflicts on members is quite hard, because known members from their's are named incomplete.
They should get the name instead and they are not incomplete.

I attach a screenshot and my osm-file.

r3074 and sun

Attachments (2)

josm_bug_4663.png (64.7 KB) - added by skyper 3 years ago.
screenshot
josm_bug_4663.osm.bz2 (186.5 KB) - added by skyper 3 years ago.
osm

Download all attachments as: .zip

Change History (16)

Changed 3 years ago by skyper

screenshot

comment:1 Changed 3 years ago by skyper

ID: 62.897

Changed 3 years ago by skyper

osm

comment:2 follow-up: Changed 3 years ago by mjulius

  • Priority changed from blocker to normal

This happens when relation members are not in the downloaded dataset, e.g. when they are outside the download bounding boxes.

It is certainly not a blocker.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 3 years ago by skyper

Replying to mjulius:

This happens when relation members are not in the downloaded dataset, e.g. when they are outside the download bounding boxes.

It is certainly not a blocker.

No this happend when using "update data" there for the bounding boxes are equal and the known ways should be the same !!!

It also happens when merging and smaller area (their) to a bigger area (my).

r3081

comment:4 Changed 3 years ago by skyper

  • Priority changed from normal to blocker

comment:5 in reply to: ↑ 3 ; follow-up: Changed 3 years ago by anonymous

  • Priority changed from blocker to normal

Replying to skyper:

Replying to mjulius:

This happens when relation members are not in the downloaded dataset, e.g. when they are outside the download bounding boxes.

It is certainly not a blocker.

No this happend when using "update data" there for the bounding boxes are equal and the known ways should be the same !!!

Yes, but if you have downloaded incomplete members of a relation or somehow else merged relation members into the dataset they might be outside the bounding boxes and not be downloaded when doing update date.

It also happens when merging and smaller area (their) to a bigger area (my).

Of course, because some relation members that are in the bigger area won't be in the smaller area and therefore incomplete in the smaller area dataset.

And please, not everything that is annoying is a blocker. This issue does not cause any real harm. There are ways to find out what those relation members are. They are just not convenient. After all you have a list of most of them on the opposite side of the dialog.

comment:6 in reply to: ↑ 5 Changed 3 years ago by skyper

Replying to anonymous:

Replying to skyper:

Replying to mjulius:

This happens when relation members are not in the downloaded dataset, e.g. when they are outside the download bounding boxes.

It is certainly not a blocker.

No this happend when using "update data" there for the bounding boxes are equal and the known ways should be the same !!!

Yes, but if you have downloaded incomplete members of a relation or somehow else merged relation members into the dataset they might be outside the bounding boxes and not be downloaded when doing update date.

No this happend with in the downloaded area but seems to be fixed now. Can not reproduce myself, but I have to say I have uploaded my changes yesterday.

It also happens when merging and smaller area (their) to a bigger area (my).

Of course, because some relation members that are in the bigger area won't be in the smaller area and therefore incomplete in the smaller area dataset.

This was different before and as conflict management is not that easy it is another trap to get caught with. In facts these members are on way with on ID and not 2 different ways. So I guess they should have the same name and yeah they might have been incomplete but through merging they exist and are not incomplete anymore.

And please, not everything that is annoying is a blocker. This issue does not cause any real harm. There are ways to find out what those relation members are. They are just not convenient. After all you have a list of most of them on the opposite side of the dialog.

Yes, with that bug fixed on "update data" you are right. Sorry

comment:7 follow-up: Changed 3 years ago by skyper

  • Keywords elements incomplete downloaded. added; conflict member name removed
  • Priority changed from normal to major
  • Summary changed from conflict manager: known members from their's are named "incomplete" to previous downloaded members show as incomplete

with r3313 this also happens if you first download a relation without primitives and afterwards download a small area. All elements of the privious downloaded relation outside downloaded area turn to incomplete in the relation-editor.

comment:8 Changed 3 years ago by skyper

  • Summary changed from previous downloaded members show as incomplete to previous downloaded members shown as incomplete

comment:9 in reply to: ↑ 7 Changed 3 years ago by skyper

  • Priority changed from major to normal

Replying to skyper:

with r3313 this also happens if you first download a relation without primitives and afterwards download a small area. All elements of the privious downloaded relation outside downloaded area turn to incomplete in the relation-editor.

Forget that this was my fault.

Sorry

comment:10 Changed 3 years ago by skyper

  • Keywords conflict element added; elements downloaded. removed
  • Summary changed from previous downloaded members shown as incomplete to conflict manager: known elements from their's are named "incomplete"

comment:11 Changed 2 years ago by skyper

Problem still exists with r3732.

comment:12 Changed 15 months ago by skyper

  • Description modified (diff)

Still some known members shown as incomplete:

relation id: 62897, way id: 27545690

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2012-02-15 02:32:11
Last Changed Author: xeen
Revision: 4934
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2012-02-15 02:44:53 +0100 (Wed, 15 Feb 2012)
Last Changed Rev: 4934

Identification: JOSM/1.5 (4934 en)
Memory Usage: 58 MB / 508 MB (1 MB allocated, but free)
Java version: 1.6.0_18, Sun Microsystems Inc., OpenJDK Client VM
Operating system: Linux

comment:13 Changed 15 months ago by skyper

  • Keywords manager added

comment:14 Changed 10 months ago by skyper

  • Resolution set to fixed
  • Status changed from new to closed

Can not reproduce with r5329, -> fixed.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.