Plugin download broken

[stoecker]

The reworked plugin handling is broken completely regarding the fact whether plugins need to be updated or not.

It seems to code to check for update necessarity is gone totally, but the previously very clean plugin interface which was grouped at one place is now spread over so much files that it is very hard to understand it at all. Each place replicates the same functionality(e.g.) updating) that understanding takes a long time.

The "only download plugins requiring update" functionality must be restored before next release.

[bastiK]

You could have come up with this a little earlier, seriously...

Gubaer says, that the "only download plugins requiring update" functionality was never there in the first place. (See #4443) I havened checked thoroughly, but at least in [2817] nothing like this was deleted.

[stoecker]

That's wrong. Before the rework it did only download when version mismatched. See e.g. PluginSelection.update() function of 2800. There is the version check.

Plugin handling was the main reason why we had no release in January and I though this was fixed (you said so somewhere). Now I did a test of the crossing way validator report and detected that it is still broken.

[stoecker]

As there are still bugs and the texts of #4443 don't convince me that Gubaer really understood the plugin stuff he reworked totally it also should be verified, that the feature to load old plugins works reliable. The manifest and/or the plugin information contains links to older versions. Older JOSM versions need to download these instead of the current version.

[stoecker]

Actually the whole functionaility of the update() function is missing (which asked the user if he really is happy with the download).

[skyper]

Seems to me that #4443 and #4565 have to do with this, too

[anonymous]

Not related to the release anymore.