Modify

Opened 3 years ago

Closed 3 years ago

#4606 closed enhancement (fixed)

merging a new and an already existing node

Reported by: anonymous Owned by: team
Priority: normal Component: Core
Version: latest Keywords: merge new node
Cc:

Description

If you merge a newly created node to an existing node, the existing node should not be deleted.

node(ID:-1) + node(ID:1234) --merge--> node(ID:1234)

Attachments (0)

Change History (9)

comment:1 Changed 3 years ago by mjulius

Since r2341 Merge Nodes always merges onto the last selected node.

comment:2 Changed 3 years ago by vsandre

Please introduce it anyway. A little bit lesser database flooding.

BTW I checked the new behaviour out, after reporting this bug. Nice feature.

comment:3 follow-up: Changed 3 years ago by Gubaer

  • Type changed from defect to enhancement

Trying to reformulate:

  • When a ordered list of nodes [node_1,node_2,..., node_n] (in the order of selection, first selected node first, last selected node last) are merged using Tools-Merge Nodes one of the nodes becomes the target node. The other nodes are deleted.
  • Current situation: the last node node_n becomes the target node
  • Proposed enhancement in this ticket: select the last non-new node as target node. If no such node exists, still select the last node.

comment:4 in reply to: ↑ 3 Changed 3 years ago by mjulius

Replying to Gubaer:

  • Proposed enhancement in this ticket: select the last non-new node as target node. If no such node exists, still select the last node.

And the target node should get the coordinates of the last selected node. This was the point of r2341.

comment:5 follow-up: Changed 3 years ago by Gubaer

And the target node should get the coordinates of the last selected node. This was the point of r2341.

Right. I give it another try:

  • When an ordered list of nodes [node_1,node_2,..., node_n] (in the order of selection, first selected node first, last selected node last) are merged using Tools->Merge Nodes one of the nodes becomes the survinging node. The other nodes are deleted.
  • Current situation: the last node node_n becomes the survinging node
  • Proposed enhancement in this ticket: select the last non-new node as surviving node. If no such node exists, select the last selected node. The surviving node is always assigned the position of the last selected node.

comment:6 in reply to: ↑ 5 Changed 3 years ago by vsandre

Replying to Gubaer:

And the target node should get the coordinates of the last selected node. This was the point of r2341.

Right. I give it another try:

  • When an ordered list of nodes [node_1,node_2,..., node_n] (in the order of selection, first selected node first, last selected node last) are merged using Tools->Merge Nodes one of the nodes becomes the survinging node. The other nodes are deleted.
  • Current situation: the last node node_n becomes the survinging node
  • Proposed enhancement in this ticket: select the last non-new node as surviving node. If no such node exists, select the last selected node. The surviving node is always assigned the position of the last selected node.

+1

comment:7 follow-up: Changed 3 years ago by skyper

  • Keywords merge new node added

If JOSM could revert changes on server I think it would be data the best to keep the lowest id and use the last node as (new) position.

comment:8 in reply to: ↑ 7 Changed 3 years ago by skyper

Replying to skyper:

If JOSM could revert changes on server I think it would be data the best to keep the lowest id and use the last node as (new) position.

comment:9 Changed 3 years ago by bastiK

  • Resolution set to fixed
  • Status changed from new to closed

(In [3134]) fixed #4606 - merging a new and an already existing node (better selection of "surviving" node)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.