Modify

Opened 3 years ago

Closed 2 years ago

#4564 closed enhancement (fixed)

conflict manager: highlight conflict on properties

Reported by: skyper Owned by: team
Priority: normal Component: Core
Version: latest Keywords: conflict
Cc: skyper

Description

Hi

Please also highlight a conflict on properties (red square) within the conflict manager, like it is done with the other 3 categories.

Thanks

Attachments (2)

layer_bug1.osm (306 bytes) - added by skyper 2 years ago.
file one
layer_bug2.osm (324 bytes) - added by skyper 2 years ago.
file two

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by skyper

  • Type changed from defect to enhancement

comment:2 Changed 2 years ago by skyper

Hey guys.

One and a have year past and I stumbled over this again. Took me about two hours to figure out.

So please.

r4114

Last edited 2 years ago by skyper (previous) (diff)

comment:3 follow-up: Changed 2 years ago by stoecker

Do you have a test file, which causes a corresponding conflict when uploaded?

comment:4 in reply to: ↑ 3 Changed 2 years ago by skyper

Replying to stoecker:

Do you have a test file, which causes a corresponding conflict when uploaded?

Thought you know how to create a conflict !

  1. Just download the same node twice in different layers
  2. move both.
  3. merge both layers you get a conflict.

but anyway, here you go. Just merge the two files.

Changed 2 years ago by skyper

file one

Changed 2 years ago by skyper

file two

comment:5 follow-up: Changed 2 years ago by stoecker

Well, I tried and it works for me as expected.

comment:6 in reply to: ↑ 5 Changed 2 years ago by skyper

Replying to stoecker:

Well, I tried and it works for me as expected.

You have a red box for tags but there is not red box for properties. Thus you focus on the conflict on tags and once switched to tags you do not get any information about the conflict in properties. (red box is missing)

comment:7 Changed 2 years ago by stoecker

Yeah I see it. I looked at wrong place till now.

comment:8 Changed 2 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

In [4115/josm]:

fix #4564 - conflict manager: highlight conflict on properties

comment:9 Changed 2 years ago by skyper

  • Resolution fixed deleted
  • Status changed from closed to reopened

Now the red box stays there even without a conflict. Should it not vanish or change to a green ccheckmark ?

comment:10 Changed 2 years ago by stoecker

  • Resolution set to fixed
  • Status changed from reopened to closed

In [4116/josm]:

fix #4564 - conflict manager: highlight conflict on properties

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.