Modify

Ticket #4543 (closed defect: invalid)

Opened 2 years ago

Last modified 2 years ago

Merge problem: potential defect in merge logic

Reported by: Gubaer Owned by: team
Priority: critical Component: Core
Version: latest Keywords: merge
Cc: skyper

Description

Creating a new ticket from a message in #4509, see also  attached file.

Not qualifying as r-2010-01-blocker yet, needs analysis first.


Sorry for making so much work, but weekend is over and I am back again.

I think there is still a bug in merging. I have to older osm of the same region. I think the only thing I edit is deleting errors (overlaping way, doubled nodes). I do not find any id:0.

I merge this files and only get conflicts of nodes, but there exist ways in one osm that do not exist in the other one. I think there should be an conflict on but please tell me if I am wrong. Look for the round-about "Siegesdenkmal" and there at the low left. I also noticed that there is no conflict of a relation, but this way (42667459) still exists but lost its membership.

I merged the older file onto the new, but I think it also is not working right the other way round. May we have to open another ticket.

Cheers skyper

Attachments

Change History

comment:1 Changed 2 years ago by skyper

  • Keywords merge added
  • Priority changed from normal to critical
  • Version set to latest

comment:2 Changed 2 years ago by skyper

  • Cc skyper added

comment:3 in reply to: ↑ description Changed 2 years ago by mjulius

Replying to Gubaer:

I merge this files and only get conflicts of nodes, but there exist ways in one osm that do not exist in the other one. I think there should be an conflict on but please tell me if I am wrong. Look for the round-about "Siegesdenkmal" and there at the low left.

Why should there be a conflict? When an object in the source dataset is not in the target dataset it is simply added. That is the point of merging.

I also noticed that there is no conflict of a relation, but this way (42667459) still exists but lost its membership.

Because relation 71504 has a newer version in newer.osm and therefore this version is kept.

comment:4 Changed 2 years ago by Gubaer

  • Status changed from new to closed
  • Resolution set to invalid

Doesn't look like a "conflict" in the sense JOSM is using the term. See #4509 for a discussion on how "potential map anomalies" could be treated in the future.

Closing as invalid.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.