Modify ↓

Ticket #4439 (closed defect: fixed)

Opened 2 years ago

Last modified 6 months ago

[Patch] droping spaces in keys or value automatically

Reported by: vsandre Owned by: team
Priority: normal Component: Core
Version: tested Keywords:
Cc:

Description

At the moment josm drops spaces at the end of a key or value only in the properties dialogue. This service should be extended for entries in the presets or relation editor.

Attachments

4439.patch Download (32.9 KB) - added by simon04 6 months ago.

Change History

comment:1 Changed 2 years ago by anonymous

  • Keywords r-2010-01-blocker added

comment:2 Changed 2 years ago by Gubaer

  • Keywords r-2010-01-blocker removed

Please log in or leave your email address to flag a ticket as release blocker.

comment:3 Changed 2 years ago by Gubaer

  • Status changed from new to closed
  • Resolution set to fixed

(In [3013]) fixed #4439: droping spaces in keys or value automatically

comment:4 Changed 2 years ago by anonymous

  • Status changed from closed to reopened
  • Resolution fixed deleted

works for relation editor but not for presets.

Changed 6 months ago by simon04

comment:5 Changed 6 months ago by simon04

  • Summary changed from droping spaces in keys or value automatically to [Patch] droping spaces in keys or value automatically

This should be fixed in the attached patch.

I took the opportunity to remove a lot of duplicate code inside TaggingPreset by combining common parts of Combo and MultiSelect in a new abstract class ComboMultiSelect.

comment:6 Changed 6 months ago by stoecker

NOTE to team: This will need proper review, as handling of tagging presets is easily broken.

@simon04: Please continue with this speed until all JOSM core bugs are fixed ;-)

comment:7 Changed 6 months ago by stoecker

  • Status changed from reopened to closed
  • Resolution set to fixed

In [4340/josm]:

fix #4439 - patch by simon04 - remove useless spaces in tagging presets, remodeduplicate code - please report regressions in tagging presets if there are any

View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.