right click menu "cut, copy, paste" for each text component in josm

[bastiK]

On most platforms you can copy text by right clicking on the selection and then choose copy from the context menu.

Some users will miss this and it certainly adds to the foreign feel when using java apps.

The java bug for this:
​http://bugs.sun.com/view_bug.do?bug_id=4818418

[anonymous]

Patch for context menu

[anonymous]

The textfield.patch adds a right click menu to the JTextField.
It's a basic variant and adapted from the sun example.

[Don-vip]

Thanks for the patch, this is highly appreciated. Some work remains to be done before being considered for merging:

1. org.openstreetmap.josm.gui.MyTextField should become org.openstreetmap.josm.gui.widgets.JosmTextField
2. All text displayed must be translated by using JOSM translation system (example: "Paste" becomes tr("Paste"), with import static org.openstreetmap.josm.tools.I18n.tr;
3. The Sun patch is Windows-oriented. Has this patch been tested under Linux as well ?
4. Please no debug stuff (the main method in comments). Unused imports should be removed instead of being commented.
5. We credit patch authors. Who are you ? :)

[anonymous]

You are welcome.

To your remarks/questions:

1./2./4. I changed the patch accordingly.

3. It's more the otherway around. I only have Linux, so the patch is not tested on Mac or Windos.
4. You can credit the patch to: NooN.

ToDo:

1. I don't hade time to change alle instances of JTextField in the preference part of the source
2. Tests have to be done on Windows and Mac.
3. Some Combo Boxes don't profit from the patch
4. Someone should look over the constructor/super stuff in JosmTextField if this is "java like". My java knowlege is very limited and this was more try and error.

[noon]

Patch for context menu, version 2

[NooN]

In the new patch "josmtextfield_02.patch" I changed also the JTextField in the prefernce part of the source. So the ToDo point 1 is done.
The ToDo point 3: I tried to implemened the context menu for the HistoryComboBox but it did not work. I want this feature for the PlaceSelection dialog.

I don't have a Windows/Mac computer so I can't test the ToDo point 2
For ToDo point 4 is my java knowledge limited. Someone should check patch befor commiting.

[Don-vip]

Thanks for this new version :) New status:

1. OK
2. OK
3. OK on Windows 8. I will ask a Mac user to make some tests after we commit this patch, so all OK.
4. OK
5. OK
6. Popup menu should be refactored to a new class to avoid duplicate code. Something like org.openstreetmap.josm.gui.widgets.TextContextualPopupMenu.
7. I confirm the popup does not work with HistoryComboBox.
8. Please no new public classes/methods without Javadoc. See DevelopersGuide/StyleGuide

I look into those points.

[Don-vip]

In 5884/josm:

see #4429 - Get popup menu from PopupMenuLauncher + fix javadoc

[Don-vip]

In 5886/josm:

see #4429 - Right click menu "undo, cut, copy, paste, delete, select all" for each text component (originally based on patch by NooN)

[Don-vip]

Quite a big patch :)
Didn't see particular problem with my tests under Windows 8
Can you make some tests on Linux ?

@akks: I have removed "paste tag" and "paste value" from the contextual menu of AddTagDialog with this change, you understand why :)

[NooN]

I don't get a connection with the version 5899.

The input boxes I tested worked under Linux

There is no german translation for cut.

Thanks for getting the patch submitted.

[Don-vip]

Replying to NooN:

I don't get a connection with the version 5899.

Unrelated to this subject, see #8627

The input boxes I tested worked under Linux

Nice :)

There is no german translation for cut.

You can help, everyone can contribute to JOSM translations, see Translations.

Thanks for getting the patch submitted.

Welcome, thanks for starting it !

[Don-vip]

No related issue reported.
Please reopen if something is wrong with these new contextual menus.

[Don-vip]

Ticket #6627 has been marked as a duplicate of this ticket.