Modify

Ticket #4059 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Relation history window does not show up

Reported by: Nakor Owned by: Nakor
Priority: normal Component: Core
Version: latest Keywords:
Cc:

Description (last modified by Gubaer) (diff)

If I select a relation and ask for its history, the history is downloaded from OSM but the history window never shows up afterwards.

Closing as worksforme.

Attachments

HistoryRelationMemberException.patch (1.2 KB) - added by mjulius 2 years ago.

Change History

comment:1 Changed 2 years ago by Nakor

Ticket #4058 has been marked as a duplicate of this ticket.

comment:2 Changed 2 years ago by mjulius

  • Owner changed from team to Nakor
  • Status changed from new to needinfo

I can not reproduce that in r2554. What exactly are you doing (step-by-step)?

comment:3 follow-up: ↓ 4 Changed 2 years ago by Nakor

I cannot reproduce it any more. I do not know if this can be on any help, but this was on an out-dated relation (i.e. a modification that has been modified on OSM in the meantime).

comment:4 in reply to: ↑ 3 Changed 2 years ago by Gubaer

  • Status changed from needinfo to closed
  • Resolution set to worksforme
  • Description modified (diff)

Replying to Nakor:

I cannot reproduce it any more. I do not know if this can be on any help, but this was on an out-dated relation (i.e. a modification that has been modified on OSM in the meantime).

comment:5 Changed 2 years ago by mjulius

  • Status changed from closed to reopened
  • Resolution worksforme deleted

I was able to narrow down the issue using the data attached to #4060.

The issue comes up when one tries to show the history of a modified relation that has a new way added. In this case JOSM wants to add the current data to the history as "latest" and RelationMember throws an IllegalArgumentException when the new way (with negative ID) is to be added. And because this is happening in a sub-thread this exception is ignored. (This is probably a bug on its own.)

The attached patch simply gets rid of the exception.

Changed 2 years ago by mjulius

comment:6 Changed 2 years ago by jttt

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [2561]) Applied #4059 by mjulius - Relation history window does not show up

comment:7 Changed 2 years ago by anonymous

Ticket #4072 has been marked as a duplicate of this ticket.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.