Modify

Opened 4 years ago

Closed 3 years ago

#3935 closed defect (worksforme)

Join overlapping Areas on only slightly overlapping polygons drops 1 polygon

Reported by: Ldp Owned by: Ldp
Priority: normal Component: Core
Version: Keywords:
Cc:

Description

NPE when trying to join the 2 areas in the attached file. The nodes where the two areas appear to be touching are actually a very small distance apart. If I merge these first, then I can join the areas without problem.

JOSM built with ant clean dist. Plugins updated.

Build-Date: 2009-11-15 00:30:43		
Revision: 2454
Is-Local-Build: true

Memory Usage: 22 MB / 1016 MB (1 MB allocated, but free)
Java version: 1.6.0_17

Plugins: AddrInterpolationremotecontrolutilspluginvalidatorwmsplugin
Plugin AddrInterpolation Version: 18503
Plugin remotecontrol Version: 18503
Plugin utilsplugin Version: 18503
Plugin validator Version: 18600
Plugin wmsplugin Version: 18597


java.lang.NoSuchMethodError: org.openstreetmap.josm.data.osm.DataSet.setSelected([Lorg/openstreetmap/josm/data/osm/OsmPrimitive;)V
	at UtilsPlugin.JoinAreasAction.joinWays(JoinAreasAction.java:609)
	at UtilsPlugin.JoinAreasAction.joinOuterWays(JoinAreasAction.java:572)
	at UtilsPlugin.JoinAreasAction.joinAreas(JoinAreasAction.java:213)
	at UtilsPlugin.JoinAreasAction.actionPerformed(JoinAreasAction.java:170)
	at javax.swing.SwingUtilities.notifyAction(Unknown Source)
	at javax.swing.JComponent.processKeyBinding(Unknown Source)
	at javax.swing.KeyboardManager.fireBinding(Unknown Source)
	at javax.swing.KeyboardManager.fireKeyboardAction(Unknown Source)
	at javax.swing.JComponent.processKeyBindingsForAllComponents(Unknown Source)
	at javax.swing.JComponent.processKeyBindings(Unknown Source)
	at javax.swing.JComponent.processKeyEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (1)

test-join-areas-3935.osm (3.9 KB) - added by Ldp 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by Ldp

comment:1 Changed 4 years ago by jttt

I've fixed the NoSuchMethodError (not NullPointerException as stated in ticket). Anyway the result of join areas action is probably not correct...

comment:2 Changed 4 years ago by Gubaer

  • Resolution set to wontfix
  • Status changed from new to closed

Your JOSM version and the utilsplugin aren't in sync. Please update both.

comment:3 Changed 4 years ago by Ldp

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Summary changed from [NPE] utilsplugin, Join overlapping Areas on non-ideal geometry to Join overlapping Areas on only slightly overlapping polygons drops 1 polygon

Updated both now. I thought I did that before filing the ticket. I even said so: "JOSM built with ant clean dist. Plugins updated."

I'm now at JOSM 2473, utilsplugin 18621, where it doesn't show the java error, but does exhibit another effect: the rightmost polygon is simply gone after the join. Of course: the example has a 'flaw', in that the polygons are overlapping very slightly instead of just touching or overlapping by a wider margin.

If I make them overlap by just a tiny bit more (select the right polygon and shift-arrow it a bit into the left polygon) it also drops the right polygon, but leaves a double line where they overlapped.

And again, if I overlap them by even more, they *are* correctly joined, and the resulting polygon follows the exact outline of the 2 joined polygons combined.

Is the join behaviour driven by distance or amount of overlap?

comment:4 Changed 4 years ago by stoecker

  • Status changed from reopened to new

comment:5 Changed 3 years ago by stoecker

  • Owner changed from team to Ldp
  • Status changed from new to needinfo

Still an issue? I recently fixed join areas.

comment:6 Changed 3 years ago by stoecker

  • Component changed from Plugin to Core

comment:7 Changed 3 years ago by stoecker

  • Resolution set to worksforme
  • Status changed from needinfo to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.