Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3889 closed defect (fixed)

Upload of a single way gives changeset with lots of other existing ways

Reported by: Ldp Owned by: team
Priority: critical Component: Core
Version: Keywords:
Cc:

Description

I downloaded an area in a new layer and added a single building (copy/pasted it from another layer). Then I uploaded, but the changeset now contained that building, and *lots* of other ways that I had downloaded. No existing nodes were uploaded, just lots of ways.

The way I added:
http://www.openstreetmap.org/browse/way/44098703

The changeset JOSM created:
http://www.openstreetmap.org/browse/changeset/3082764

JOSM 2427

Attachments (1)

test-ticket-3889.osm (584 bytes) - added by Ldp 4 years ago.
Test file, as mentioned in the previous comment

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by Gubaer

  • Owner changed from team to Ldp
  • Status changed from new to needinfo

I tried to reproduce:

  • downloaded an area in layer 1
  • created new layer 2
  • createed a building in layer 2
  • copy building from layer 2 in layer 1
  • upload layer 1

==> everything is fine.

Anything else which is special in your case? Did you really upload the layer which only included one new building? What did the upload dialog show? Just a couple of nodes and one way to upload?

comment:2 Changed 4 years ago by Ldp

Tried again with 2431 & 2436, with and without plugins and also doing ant clean ; ant dist.

  • Open JOSM.
  • Drop a .osm on it with things to import. Every element is still unknown to OSM (negative id)
  • Zoom in to near building to import.
  • File -> New, File -> Download from OSM
  • Activate first layer, select building, Copy, select OSM layer, Paste
  • Press upload

The upload dialog says that it wants to add 9 nodes and a way. That's fine, that's my new building. It also says it wants to *modify* 76 other objects. Objects which happen to be in the same area I downloaded from OSM, but which I definately didn't touch.

The thing you did differently is to create both layers in the same session. That works for me too. Try creating an object and save it as .osm. Doesn't have to be a building. I also triggered this bug with an untagged 4-node area. Then restart, open JOSM, open/drag the .osm on JOSM, etc. Same as I did.

Changed 4 years ago by Ldp

Test file, as mentioned in the previous comment

comment:3 Changed 4 years ago by anonymous

Same happend to me. Command stack lists 30 changes, Upload tried to edit 5000 additional ways.

Resulting changeset after cancelling upload: http://www.openstreetmap.org/browse/changeset/3086373

  • JOSM 2417 (from Website), many plugins (updated today)
  • only one layer
  • First Upload was OK

Saving results in a .osm file with > 5000 ways marked with action='modify' (in addition to the 5 relations and 6 points I actually changed.

Steps:

  • Downloaded map data
  • Edited
  • Uploaded (OK)
  • Downloaded more map data
  • Edited
  • Uploading broken

comment:4 Changed 4 years ago by anonymous

Already fixed in r2431 after #3804?

comment:5 Changed 4 years ago by Ldp

No, as I said above: I tried 2431 and 2436.

The #3804 cases also sound distinctly different.

comment:6 Changed 4 years ago by stoecker

  • Owner changed from Ldp to team
  • Status changed from needinfo to new

Dounds like the data merge function sets "modified" flag also for downloaded data.

comment:7 Changed 4 years ago by anonymous

Ticket #3905 has been marked as a duplicate of this ticket.

comment:8 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from new to closed

Should be fixed in r2443.

comment:9 Changed 4 years ago by Ldp

First tests (with 2447) look good. I cannot reproduce what I described above.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.