Opened 4 years ago
Closed 3 years ago
#3810 closed defect (fixed)
Pressing Enter in download dialog doesn't initiate download anymore
| Reported by: | avar | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core |
| Version: | latest | Keywords: | |
| Cc: |
Description
On r2347. I'm pretty sure this is a regression and it worked before.
Attachments (0)
Change History (5)
comment:1 Changed 4 years ago by avar
- Resolution set to worksforme
- Status changed from new to closed
comment:2 Changed 4 years ago by avar
- Resolution worksforme deleted
- Status changed from closed to reopened
Actually:
- Open download dialog
- Select OSM/GPS layer
- Selection on download button is released
Then Enter won't download anymore.
comment:3 follow-up: ↓ 4 Changed 4 years ago by Gubaer
- Resolution set to wontfix
- Status changed from reopened to closed
AFAIK, it never did, unless the "Download" button hat focus. IMHO, this is how it should be. For instance, the download button behaves the same way: upload with enter only if the upload button has focus.
If you really necessary I could add "tabbing" with ENTER, as I did in the download dialog. You would click in the "Download GPX", then press ENTER once or twice until the download button has focus, then press ENTER to downlolad.
comment:4 in reply to: ↑ 3 Changed 4 years ago by avar
- Resolution wontfix deleted
- Status changed from closed to reopened
Replying to Gubaer:
AFAIK, it never did, unless the "Download" button hat focus. IMHO, this is how it should be. For instance, the download button behaves the same way: upload with enter only if the upload button has focus.
It did work in the past actually. If I build r2300 and:
- Open the download dialog
- Select/Unselect OSM/GPX so that there's a small box around it
- Press Enter
Nothing happens in trunk but r2300 initiates the download. It's as if there's an Enter listener on the entire area of the dialog in r2300 but not in trunk.
Having it work like this on the download dialog isn't going to destroy any data, unlike potentially on the upload dialog.
For what it's worth this made a minor part of my workflow with JOSH slightly more tedious, hence filing the bug:)
Reopening since it did work in the past, but you can do what you want with it.
I could add "tabbing" with ENTER, as I did in the download dialog. You would click in the "Download GPX", then press ENTER once or twice until the download button has focus, then press ENTER to downlolad.
How did this work before the layout of the dialog was changed? Then one only needed to press Enter once.
comment:5 Changed 3 years ago by Gubaer
- Resolution set to fixed
- Status changed from reopened to closed
Hrm, actually the focus got out of wack somehow and I can't reproduce it now...