Modify

Opened 4 years ago

Closed 4 years ago

#3565 closed defect (fixed)

[PATCH] Typo and string unification for exceptions

Reported by: Claudius Henrichs <claudius.h@…> Owned by: stoecker
Priority: minor Component: Core
Version: Keywords:
Cc:

Description

Please find attached a larger patch with unifications for exception strings. Mainly it's uppercasing the first character. I understand that you might not want to apply the full patch as it would result in large parts of translations being redone.

If you don't apply the full patch please fix the typo in
src/org/openstreetmap/josm/io/OsmChangesetParser.java

  • throwException(tr("illegal nummeric value for attribute {0}. Got {1}", "id", id));

+ throwException(tr("Illegal numeric value for attribute {0}. Got {1}", "id", id));

Attachments (2)

typo_and_unification.diff (14.2 KB) - added by Claudius Henrichs <claudius.h@…> 4 years ago.
typo_and_unification_reloaded.diff (41.1 KB) - added by Claudius Henrichs <claudius.h@…> 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Claudius Henrichs <claudius.h@…>

comment:1 Changed 4 years ago by stoecker

  • Owner changed from team to Claudius Henrichs <claudius.h@…>
  • Status changed from new to needinfo

No problem applying it, but please be consistent.

  • All these strings should be uppercase then - you again separated equal strings. (LANG=en grep "tr(\"[a-z]" -r src)
  • All ", got" should be ". Got".
  • Add dots at end of sentences.

I will take care of the translation updates so the translations don't get lost.

Changed 4 years ago by Claudius Henrichs <claudius.h@…>

comment:2 Changed 4 years ago by Claudius Henrichs <claudius.h@…>

  • Owner changed from Claudius Henrichs <claudius.h@…> to stoecker
  • Status changed from needinfo to new

(It all started with a simple typo to fix...)

I've manually skimmed through all files in org/openstreetmap/josm/io/ and applied the valid remarks you had. You can find it in the typo_and_unification_reloaded.diff file that is attached

comment:3 Changed 4 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

In r2181 with lots of other changes.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.