Ticket #3531 (reopened defect)
Validator - false positives in "way end node near other way"
| Reported by: | singularita@… | Owned by: | dmuecke |
|---|---|---|---|
| Priority: | normal | Component: | Plugin validator |
| Version: | latest | Keywords: | unconnected_way |
| Cc: |
Description (last modified by mdk) (diff)
Check for "way end node near other way" is useful, however in some areas it finds many false positives.
Minimal distance to trigger this warning seems to be 10 (by default).
But what unit it is? when the preference is read, the number is divided by some arbitrary number 6378135.0 What is meaning of that number? No documentation in the source
I've collected some examples of false positives found by validator, along with some ideas how to avoid them:
validator-deadend.png - T-junction near end of way
There is branching (T-junction) close to end of way. This shows false alarm, even though the way in warning is connected to the way with the endnode.
validator-platform.png - Parallel railway tracks or platforms
Railway platforms or tracks running in parallel - these can be as close as 5 meters. Have some smaller distance to trigger the warning, if both ways (the one with end node and the one close to the node) are parallel or very close to parallel
validator-powerline.png - highway end node close to powerline
validator-stream-road.png - highway end node close to stream
Sometimes features are running quite close to each other "by design". Power lines often are placed with little regard of what is below them and endpoint of highway ending up near powerline is surely not connected to it. Sometimes stream run right behind the streets (the streets are ended just before the stream) and they are also not connected
Therefore for "incompatible" features (highway vs waterway, powerline vs waterway/railway/highway) that should not be probably connected (highway connected to the powerline does not make sense), the distance should be lower too.
I think for these cases, some lower distance threshold (one quarter by default, perhaps ....) should be used
Attachments
Change History
Changed 3 years ago by singularita@…
- Attachment validator-platform.png added
Parallel railway tracks or platforms
Changed 3 years ago by singularita@…
- Attachment validator-powerline.png added
highway end node close to powerline
Changed 3 years ago by singularita@…
- Attachment validator-stream-road.png added
highway end node close to stream
comment:1 Changed 3 years ago by dmuecke
- Owner changed from team to dmuecke
- Status changed from new to assigned
comment:2 Changed 2 years ago by skyper
- Keywords validator added
I think in all these example there should be a warning as long as the highway does not end with noexit=yes, but it should not be refered to a way with a different layer=* .
comment:3 Changed 18 months ago by bastiK
Ticket #4363 has been marked as a duplicate of this ticket.
comment:4 Changed 18 months ago by skyper
- Keywords way node added
- Component changed from Plugin validator to Core
Validator is in Core now
comment:5 Changed 15 months ago by skyper
- Status changed from assigned to closed
- Resolution set to fixed
- Component changed from Core to Plugin validator
Seems to be fixed
comment:6 Changed 15 months ago by skyper
- Status changed from closed to reopened
- Resolution fixed deleted
Sorry. Validator does not find any "way end node near other way" right now
Changed 13 months ago by skyper
- Attachment validator_WayEndNodeNearWay_example.osm added
example file
comment:8 Changed 13 months ago by skyper
Ticket #5837 has been marked as a duplicate of this ticket.
comment:9 follow-up: ↓ 11 Changed 13 months ago by skyper
Validator also warns about "way end node near other way" with untagged ways which are only part of landuse-relations as "other way" . Think this is a false positiv, too.
comment:10 Changed 12 months ago by skyper
Ticket #4257 has been marked as a duplicate of this ticket.
comment:11 in reply to: ↑ 9 Changed 11 months ago by skyper
Replying to skyper:
Validator also warns about "way end node near other way" with untagged ways which are only part of landuse-relations as "other way" . Think this is a false positiv, too.
Everything except the unntagged way is still an issue. Please, do check the main tag of both ways and filter to only check for ways with the same main tag. Thanks
comment:12 Changed 11 months ago by skyper
Ticket #5435 has been marked as a duplicate of this ticket.
comment:13 Changed 9 months ago by simon04
Ticket #6313 has been marked as a duplicate of this ticket.
Changed 6 months ago by mdk
- Attachment falsePositive.osm added
It looks like this issue is not so clear, but it huts me every day. So I add a more clear example with a highway near a poweline, a waterway and a barrier. I hope this will help to solve the problem.
comment:14 Changed 6 months ago by mdk
- Description modified (diff)
Ping :-)
(BTW why dose attaching a file did not effect 'last change date' of the issue in trac?)
comment:15 Changed 6 months ago by simon04
- Keywords unconnected_way added; validator way node removed


