Modify

Opened 4 years ago

Closed 4 years ago

#3402 closed defect (fixed)

Conflict in created_by when merging nodes or ways

Reported by: anonymous Owned by: team
Priority: normal Component: Core
Version: latest Keywords:
Cc: osm@…

Description

When I merge two nodes or ways, sometimes I get useless conflict in "created_by" tags (usualy with two choices like "Potlatch 0.9" and "Potlatch 0.8" or alike)

I think these cases should be handled automatically - as JOSM is dropping created_by on upload anyway, these tags should be automatically dropped during the merge and save hassle with the dialogs.

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by stoecker

  • Resolution set to wontfix
  • Status changed from new to closed

The former special code to handle this case has been dropped already. created_by vanishs over the time and so will these warnings.

comment:2 Changed 4 years ago by malenki

  • Cc osm@… added
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Nice error-handling. So to prevent such conflicts one should remove all created_by-tags in advance? If not, how is josm/the mapper supposed to handle that error?

comment:3 Changed 4 years ago by Ldp

You make us jump through hoops to resolve created_by conflicts, when they won't be uploaded to OSM anyway? Yeah, great usability decision there.

comment:4 Changed 4 years ago by Gubaer

Actually, the created_by tag is sillently dropped when combining ways or merging nodes.

I assume there isn't a problem anymore, is there? Which "usability decision" are you not happy with? The silent dropping of created_by ?

comment:5 Changed 4 years ago by Ldp

The way I read stoecker's first comment was that there are still warnings, and by my own extrapolation that you still have to resolve the conflict during a merge.

I was working with 2094, where you still get the combine popup with conflicts to resolve, when the only difference is in the created_by tags.

I now tested 2099 and there it merges without dialog, so that's good. It does set the resulting created_by tag to the value of one of the ways. There is an opportunity to already drop created_by when combining ways, in this case.

comment:6 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2104]) fixed #3402: Conflict in created_by when merging nodes or ways (created_by now dropped during combine way and merge node)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.