Modify

Opened 4 years ago

Closed 4 years ago

#3382 closed defect (fixed)

Opening a /user/ page fails for usernames with a space (" ") in them

Reported by: avar Owned by: team
Priority: major Component: Core
Version: latest Keywords:
Cc:

Description

Usernames that have spaces in them e.g. "Ævar Arnfjörð Bjarmason" will be opened as http://www.openstreetmap.org/user/%C3%86var.

This bug was introduced in r2034 (see ticket:3379).

To reproduce try opening the dump of Iceland and doing a wildcard search.

Attachments (0)

Change History (5)

comment:1 follow-up: Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from new to closed

(In [2042]) fixed #3382: Opening a /user/ page fails for usernames with a space (" ") in them

comment:2 in reply to: ↑ 1 Changed 4 years ago by avar

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to Gubaer:

(In [2042]) fixed #3382: Opening a /user/ page fails for usernames with a space (" ") in them

This is still broken. If I click on my username JOSM sends me to Ævar+Arnfjörð+Bjarmason instead of the correct Ævar Arnfjörð Bjarmason. I.e. it escapes " " as "+" instead of "%20".

comment:3 follow-up: Changed 4 years ago by Gubaer

Not sure whether this is a defect on JOSMs side. Isn't it perfectly "legal" to encode a blank with either %20 or + according to the RFC ?

Anyway, in case of OSM web site we probably better switch to %20-encoding.

comment:4 in reply to: ↑ 3 Changed 4 years ago by Mormegil

Replying to Gubaer:

Not sure whether this is a defect on JOSMs side. Isn't it perfectly "legal" to encode a blank with either %20 or + according to the RFC ?

No, a space in the path component of a HTTP URI must be encoded as %20. See RFC 3986, section 3.3, the “+” character is a normally valid character in that part of a URI (as a member of sub-delims), and does not encode any other character. Some web servers/software might use + as an encoding for space (and escape “+” characters, if they can appear in the specific context, using percent encoding), but that is entirely their local choice, not a universal standard.

comment:5 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2073]) fixed #3382: Opening a /user/ page fails for usernames with a space (" ") in them

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.