Modify

Opened 4 years ago

Closed 4 years ago

#3340 closed defect (fixed)

NPE with remoteControl-plugin after cancelling download (RequestProcessor$2)

Reported by: vsandre Owned by: framm
Priority: normal Component: Core remotecontrol
Version: latest Keywords: NPE remoteControl
Cc:

Description

After cancelling a data download with the remoteControl-plugin, i get the following exception:

RemoteControl received: GET /load_and_zoom?left=7.76500&bottom=46.05789&right=7.
79753&top=46.07531 HTTP/1.1
GET http://www.openstreetmap.org/api/capabilities... OK
Kommunikation mit http://www.openstreetmap.org/api mittels Protokollversion 0.6
etabliert.
GET http://www.openstreetmap.org/api/0.6/map?bbox=7.765,46.05789,7.79753,46.0753
1
27.08.2009 12:17:45 org.openstreetmap.josm.actions.downloadtasks.DownloadOsmTask
$Task realRun
WARNUNG: Ignoring exception because download has been cancelled. Exception was:
{0}org.openstreetmap.josm.io.OsmTransferException: java.net.SocketException: soc
ket closed
java.lang.NullPointerException
        at org.openstreetmap.josm.plugins.remotecontrol.RequestProcessor$2.run(R
equestProcessor.java:214)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source
)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

Should I ignore this, as mentioned in the exception? If yes, could JOSM ignore this too and display a popup with "The download initiated by the plugin RemoteControl was cancelled." instead.

Attachments (0)

Change History (8)

comment:1 follow-up: Changed 4 years ago by plaicy

I looks like you have two exceptions: SocketException and NullPointerException. After the first is ignored, the second is raised.

This is caused because (Main.map==null)
(Main.map.mapView==null). After your download there should not have been any data layer. One solution would be to check for this condition.

comment:2 in reply to: ↑ 1 Changed 4 years ago by vsandre

Replying to plaicy:

I looks like you have two exceptions: SocketException and NullPointerException. After the first is ignored, the second is raised.

This is caused because (Main.map==null)
(Main.map.mapView==null). After your download there should not have been any data layer. One solution would be to check for this condition.

Yes I started JOSM, clicked on a JOSM-remote-URL and the loading window displayed. But after two minutes of waiting, because nothing else happened, I cancelled the process and get this failure.
And yes I have not got a data layer, only the today's message screen.

comment:3 Changed 4 years ago by stoecker

  • Component changed from Plugin to Core remotecontrol
  • Owner changed from team to framm

comment:4 Changed 4 years ago by anonymous

Ticket #3957 has been marked as a duplicate of this ticket.

comment:5 Changed 4 years ago by anonymous

Ticket #3956 has been marked as a duplicate of this ticket.

comment:6 Changed 4 years ago by anonymous

  • Summary changed from NPE with remoteControl-plugin after cancelling download to NPE with remoteControl-plugin after cancelling download (RequestProcessor$2)

comment:7 Changed 4 years ago by Gubaer

Should be fixed in [o18678]

comment:8 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.