[PATCH] Restriction "no-u-turn" dont work when "via-way" has wrong orientation

[anonymous]

The restriction "no-u-turn" dont work when "via-way" has wrong orientation. More (in german) see here:  http://forum.openstreetmap.org/viewtopic.php?id=4438

[dmuecke]

JOSM does suppress now drawing u-turn sign if via isn't a node and doesn't mark it an error any longer. Attached patch should fix the issue.

[stoecker]

Why do you disable drawing the turn-sign in case of via ways?

[dmuecke]

Signs looking odd. I would expect to see no left turn signs rather.

[Dennis]

The patch isn't integrated in version 1998? I have no Compiler for testing the patch. -- Dennis

[dmuecke]

Not as long as Trac resolution status isn't fixed.

[stoecker]

I'm not happy with the current patch. First I do not like disabling the icon and second I think the patch is not exactly how it should be (I can't describe better ATM).

[Dennis]

Okay, that right too. Thanks. I am a little confused, because I ha've read over the word "suppress" yesterday... ;)

[dmuecke]

After taking a nap I think I know what to change. The place on the map where u-turn restriction signs were drawn is wrong. I'm going to fix it when I'm back from holiday.

[dmuecke]

Issue fixed, patch attached!

[stoecker]

Some minor things: The "oneway" check needs to use the OsmUtils to check for "true" value. Also could you please add all the relevant test and error cases in data/restriction.osm, so we have a reproducable test-file.

[anonymous]

no-u-turn-demo

[anonymous]

File uploaded. When you change the orientation of the oneway, you see the problem. (The postion of the icon is changes and the other restriction is marked with an "*")

[stoecker]

Sorry when I was unclear. During your coding you have thought about all correct and wrong cases (at least I hope so :-). In data directory there is a file restriction.osm which is a test-file for this. Please add all possible cases there (correct ones as well as faulty ones), so the correctness of the display can be verified anytime in future.

[dmuecke]

correct u-turn signs

[dmuecke]

Added 2 more test cases in restriction.osm (05.1 and E15).

[dmuecke]

I've removed restriction.osm from patch file and added it as separate file called test_restriction.osm. Diff did create far too much differences making it pointless for code review.

[stoecker]

(In [2087]) fixed #3306 - wrong handling of restriction via ways

[stoecker]

Applied. Sorry, not much of your patch survived the changes I did.

[dmuecke]

No probs! Look at E15! It shows no u turn sign wrongly.

[dmuecke]

It shows it only in test_restriction.osm

[dmuecke]

E12 seems also not longer working.

[stoecker]

Don't know why, but you mixed "oneway=-1". Your error example is actually correct. Reversed way and -1 is the same is correctway and oneway=yes.

Regarding E13 - Display of symbols is not suppressed when the to way is affected, as this way is not required for positioning ATM. This is a strict separation between draw as best as possible and validator. I know there may be other opinions, but it is a choice done also for multipolygons and we must be consistent.

So also in the future the fact "is displayed" does still not mean "is correct". We anyway do not check all possible errors in the display routine.

[dmuecke]

Ok, thanks for clarification.