Modify

Ticket #3289 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

[PATCH] cache.wmsplugin.expire and cache.wmsplugin.maxsize are not honored?

Reported by: alexm Owned by: xeen
Priority: normal Component: Plugin wms
Version: Keywords:
Cc:

Description

It looks to me, that the settings are not in effect.

After commenting to lines out, it seems to work as expected:

WMSPlugin.java

public WMSPlugin() {

refreshMenu();

cache.setExpire(cache.EXPIRE_MONTHLY, false); cache.setMaxSize(70, false);

}

Attachments

cachefiles.patch (5.7 KB) - added by xeen 2 years ago.

Change History

comment:1 Changed 2 years ago by xeen

  • Owner changed from team to xeen

Changed 2 years ago by xeen

comment:2 Changed 2 years ago by xeen

  • Summary changed from cache.wmsplugin.expire and cache.wmsplugin.maxsize are not honored? to [PATCH] cache.wmsplugin.expire and cache.wmsplugin.maxsize are not honored?

The patch looks huge but it's mainly cosmetic due to slightly incorrect indentation when I originally created the file. Only real change is actually in setExpire and setMaxSize which will not overwrite the in-memory value if it already exists unless it's forced. (Previously it would overwrite the values from the prefs).

comment:3 Changed 2 years ago by xeen

PS: Patch is against JOSM, not the WMS Plugin

comment:4 Changed 2 years ago by stoecker

  • Status changed from new to closed
  • Resolution set to fixed

(In [2016]) fixed #3289 - patch by xeen - cache.wmsplugin.expire and cache.wmsplugin.maxsize are not honored

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.