Modify

Opened 4 years ago

Closed 4 years ago

#3116 closed defect (fixed)

NullPointerException when creating a relation without the data layer selected

Reported by: avar Owned by: dmuecke
Priority: major Component: Core
Version: latest Keywords:
Cc:

Description

  1. Open a GPX track
  2. Don't download data
  3. Click "New relation"
java.lang.NullPointerException
	at org.openstreetmap.josm.gui.dialogs.relation.RelationEditor.updateTitle(RelationEditor.java:107)
	at org.openstreetmap.josm.gui.dialogs.relation.RelationEditor.setRelation(RelationEditor.java:132)
	at org.openstreetmap.josm.gui.dialogs.relation.RelationEditor.<init>(RelationEditor.java:99)
	at org.openstreetmap.josm.gui.dialogs.relation.GenericRelationEditor.<init>(GenericRelationEditor.java:125)
	at org.openstreetmap.josm.gui.dialogs.relation.RelationEditor.getEditor(RelationEditor.java:84)
	at org.openstreetmap.josm.gui.dialogs.RelationListDialog$2.actionPerformed(RelationListDialog.java:106)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1995)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2318)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:387)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:242)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:236)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:272)
	at java.awt.Component.processMouseEvent(Component.java:6263)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:6028)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4574)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4238)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4168)
	at java.awt.Container.dispatchEventImpl(Container.java:2085)
	at java.awt.Window.dispatchEventImpl(Window.java:2475)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Attachments (1)

show-error.patch (806 bytes) - added by plaicy 4 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 4 years ago by dmuecke

  • Owner changed from team to dmuecke
  • Status changed from new to assigned

comment:2 Changed 4 years ago by plaicy

The problem: There is no data layer this way and Main.map.mapView.getEditLayer() returns null in RelationListDialog (action performed). The NPE is also thrown if you double click in the white area of the relation component. I attach a patch which test for null earlier (does not solve the problem).

Changed 4 years ago by plaicy

comment:3 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r1866

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.