[PATCH] False positives being flagged

[delta_foxtrot2]

I get the following false positives coming up, which are deemed valid on the following URL:

​http://wiki.openstreetmap.org/wiki/Map_Features

I'd be happy to try and fix these false positives but it seems to download lists from SVN. The false positives I'm getting so far are:

• Value 'secondary_link' for key 'highway' not in presets
• Value 'wood' for key 'surface' not in presets
• Value 'mall' for key 'shop' not in presets
• Value 'dirt' for key 'surface' not in presets

I also get a bunch of 'Presets do not contain property key' warnings for the following:

• Key 'au.gov.abs:*' not in presets
• Key 'construction' not in presets
• Key 'loc_name' not in presets
• Key 'is_in:country_code' not in presets
• Key 'is_in:state' not in presets
• Key 'attribution' not in presets
• Key 'is_in:country' not in presets
• Key 'is_in:state' not in presets
• Key 'admin_level' not in presets
• Key 'old_name' not in presets
• Key 'usage' not in presets

I'm sure there are others, but that's what I get for the area covering Gympie, QLD, Australia

[stoecker]

Some of them will not be copied to presets. This warning will always exist. But some of them probably should be added to presets.

[delta_foxtrot2]

The problem with them not being in presets is it tends to confuse people, a number of the tags I listed have been bulk imported and people shouldn't mess with them and all the false positives leads to the preset warnings being less useful since real warnings are drowned out and people will ignore everything rather than things that shouldn't be warnings.

[ce]

I can imagine the tags highway=secondary_link, shop=mall and surface=dirt to be added. However surface=wood is not listed in Map Features. As we already have natural=wood and landuse=forest, I do no see much sense in adding it.

[delta_foxtrot2]

I'm starting to figure all this out in my head, this seems like 2 issues almost, the first is missing presets, the second is tags that shouldn't generate warnings.

For the missing presets that should appear they just need to be added, but there seems to be a need for a list of tags that shouldn't be presets but shouldn't throw up errors either, like the au.gov.abs tags.

I'll see if I can hack something together for the latter, the former should be easy enough for almost anyone to do.

[delta_foxtrot2]

Replying to christeck:

However surface=wood is not listed in Map Features.

I'm not sure what you're looking at but the following surfaces are listed as valid, including wood:

paved / unpaved / asphalt / concrete / paving_stones / cobblestone / metal / wood / grass_paver / gravel / pebblestone / grass / ground / earth / dirt / mud / sand / ice_road

In terms of surface=wood it's a wooden bridge, so the surface literally is made of wood, not a wooded area.

[delta_foxtrot2]

Re-checking the code in the validator plugin there is already some values being ignored that aren't in the prefix list:

On line 394 of TagChecker.java:

Arrays.asList(new String[]{"opengeodb","openGeoDB","name:","note:"})))

I just extended this to include ABS tags:

Arrays.asList(new String[]{"opengeodb","openGeoDB","name:","note:","au.gov.abs:"})))

If you take into account other tags like 'qroti:' which adds a URI and other tags and links to this site:

​http://qroti.com/cgi/placeinfo.pl?ID=9007

the list could get quite long and probably needs to have code to download a cfg file similar to other config files that are downloaded for spell check and tag check purposes.

[delta_foxtrot2]

Temporary hack that works for invalid key errors that should be ignored:

                    for(String a : Main.pref.getCollection(PreferenceEditor.PREFIX + ".startswithkeys",
                    Arrays.asList(new String[]{"opengeodb","openGeoDB","name:","note:","au.gov.abs:","qroti:","is_in:"})))
                    {
                        if(key.startsWith(a))
                            ignore = true;
                    }
                    for(String a : Main.pref.getCollection(PreferenceEditor.PREFIX + ".equalskeys",
                    Arrays.asList(new String[]{"loc_name","attribution","admin_level","old_name","usage","construction"})))
                    {
                        if(key.equals(a))
                            ignore = true;
                    }

I didn't attempt to fix shop=mall as that should be dealt with elsewhere.

[delta_foxtrot2]

I created ticket #2807 to deal with the missing presets, and I reverted this ticket to be about the validator plugin

[delta_foxtrot2]

validator.patch.gz

[delta_foxtrot2]

The patch I just uploaded is a quick and dirty hack to add an additional .cfg file into the mix that gives the validator plugin the ability to know about valid tags, even if they aren't presets.

[stoecker]

Please no tabs stops and proper indentation.

[delta_foxtrot2]

Sorry about tabs, coding habits die hard. I've reopened this bug simply to save from filing a new bug on the same issue.

As for the patch, I have some new code to cover the situation of religion and more specifically denomination.

if religion=christian, denomination can't equal sunni for example, because that's a denomination of muslim.
or if religion is specified, but no denomination that's probably cause for a warning also.

I'll clean up the code and post a new patch diffed from any new code added to svn.

[delta_foxtrot2]

validator2.patch.gz

[delta_foxtrot2]

Hopefully this patch better matches your coding policies.

Also this patch includes complex matching for tags not in prefixes.

[delta_foxtrot2]

Also I seemed to have left these out of the ignoretags.cfg by accident:

T:religion=christian|denomination=anglican
T:religion=christian|denomination=apostolic
T:religion=christian|denomination=baptist

Pretty sure everything else was included properly.

[delta_foxtrot2]

More tags:

I already added S:is_in: but it probably should just be S:is_in as these are still generating false positive warnings.

I also found cycleway=track is tripping things, so K:cycleway=track should be added to the list.

Also as I come across these errors would you prefer that I keep adding them here or create a patch or some other method?

[stoecker]

Creating a patch is perferred.

[delta_foxtrot2]

I'm searching for "missing" tags so to speak and just came across a lot of tags missing, patch has already been attached.

[delta_foxtrot2]

ignoretags1.patch.gz

[delta_foxtrot2]

Latest ignore patch has all the tags I've found to date I think should be ignored. I don't expect to find anything else for the time being.

[stoecker]

In [o16346].

[delta_foxtrot2]

validator3.patch

[delta_foxtrot2]

Ignore this patch, I attached it to the wrong bug, sorry.

[delta_foxtrot2]

ignoretags2.patch

[delta_foxtrot2]

More tags that shouldn't throw warnings.

[delta_foxtrot2]

previously this bug was closed, but validator2.patch wasn't applied

[delta_foxtrot2]

validator2.patch

[delta_foxtrot2]

reattached patch uncompressed and with correct path

[stoecker]

In [o16436].

[delta_foxtrot2]

found some more tags that shouldn't throw a warning.

[delta_foxtrot2]

thanks for applying my patches, however I've found some more tags that I think shouldn't throw warnings.

[stoecker]

In [o16967].