Modify

Ticket #2755 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

[PATCH] data error caused by duplicate node fix applied outside of the downloaded area

Reported by: Harry Wood Owned by: dmuecke
Priority: major Component: Plugin validator
Version: latest Keywords:
Cc: delta_foxtrot@…

Description

When you validate data which is outside of the downloaded area the plugin allows you to "fix" this data, which can cause nasty data errors ("dataset violates a precodition" when you try to upload)

You can reproduce this within the TIGER data along county boundary roads where there are a lot of duplicate nodes. Try to fix a node which has other (not downloaded) roads connected to it.

How to fix this though?

The plugin defaults to validating all downloaded data including data outside the downloaded area. Maybe this is wrong. Maybe it should only validate nodes within the downloaded area. Or maybe it should only allow fixing within the downloaded area. Or maybe for the duplicate nodes fix, it should give a warning similar to the message which appears if you try to delete a node outside the downloaded area (try it)

Attachments

duplicate.txt Download (2.8 KB) - added by dmuecke 3 years ago.

Change History

comment:1 Changed 3 years ago by dmuecke

  • Owner changed from team to dmuecke

comment:2 Changed 3 years ago by delta_foxtrot2

  • Cc delta_foxtrot@… added

Changed 3 years ago by dmuecke

comment:3 Changed 3 years ago by dmuecke

  • Summary changed from data error caused by duplicate node fix applied outside of the downloaded area to [PATCH] data error caused by duplicate node fix applied outside of the downloaded area

I've added a dialog box to warn users before merging nodes outside downloaded area as recommended.

comment:4 Changed 3 years ago by dmuecke

  • Status changed from new to assigned

Any reason why this patch isn't merged into JOSM?

comment:5 Changed 3 years ago by Gubaer

  • Status changed from assigned to new

Send dmuecke an email with instructions on how to apply the patches to the plugins, build the new plugins, and deploy them.

comment:6 Changed 3 years ago by stoecker

  • Status changed from new to closed
  • Resolution set to fixed

In  [o16970] (modified a bit).

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.