Ticket #2746 (reopened enhancement)
Can Validator pick up paths connected to land use boundaries ?
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | minor | Component: | Plugin validator |
| Version: | latest | Keywords: | |
| Cc: | delta_foxtrot@…, singularita@… |
Description
Several times recently I have incorrectly connected a minor path (footway, cycleway etc.) to a land use boundary rather than the intended adjacent path or road. I have only noticed either this when rendering shows the error or on later review for another reason. Is the end of a path at a land use boundary something Validator could/should detect and report on ?
Attachments
Change History
comment:2 Changed 3 years ago by delta_foxtrot2
- Cc delta_foxtrot@… added
use noexit=yes tag to indicate a dead end and that node will be ignored with recent patches I've submitted.
comment:4 Changed 2 months ago by simon04
- Summary changed from Can Validator pick up paths connected to land use boundaries ? to [Patch awaits review] Can Validator pick up paths connected to land use boundaries ?
Patch attached:
- adds utility functions
- AbstractPrimitive: boolean hasTag(String key, String... values)
- ElemStyles: AreaElemStyle getAreaElemStyle(OsmPrimitive p, boolean pretendWayIsClosed), boolean hasAreaElemStyle(OsmPrimitive p, boolean pretendWayIsClosed)
- Way: Node getFirstNode(), Node getLastNode()
- adds validation test WayConnectedToArea
Please take a look at the provided patch!
comment:5 follow-up: ↓ 7 Changed 8 weeks ago by stoecker
Way has already functions firstNode() and lastNode(). No need to reimplement them.
comment:6 Changed 7 weeks ago by simon04
- Status changed from new to closed
- Resolution set to fixed
In [4682/josm]:
comment:7 in reply to: ↑ 5 Changed 7 weeks ago by simon04
Replying to stoecker:
Way has already functions firstNode() and lastNode(). No need to reimplement them.
Right… Changed and committed.
comment:8 Changed 7 weeks ago by Don-vip
- Status changed from closed to reopened
- Resolution fixed deleted
There are plenty of false positives with this new warning, like a highway ending on a roundabout, a footway ending on a building entrance... This check should be be only restricted to landuse boundaries right now, and extended to other specific cases if needed.
comment:9 Changed 7 weeks ago by simon04
- Status changed from reopened to closed
- Resolution set to fixed
In [4704/josm]:
comment:10 Changed 6 weeks ago by Don-vip
- Status changed from closed to reopened
- Resolution fixed deleted
Sorry to reopen again this ticket :) I have another case where this warning should not happen: when a landuse share a way segment with a highway A, and another highway B connects to A:
_____ highway A
/
|
-----------|
| |
| landuse |-------- highway B
| |
-----------|
|
This is perfectly valid :)
comment:11 Changed 6 weeks ago by stoecker
- Summary changed from [Patch awaits review] Can Validator pick up paths connected to land use boundaries ? to Can Validator pick up paths connected to land use boundaries ?




Yes I think this is a common problem with roads as well as footways.
I know a lot of mappers deliberately connect footways to landuse areas as well as continuing it to the adjacent path/road. So the connection itself is not an error, but maybe a if the footpath terminates at the connection with landuse, this could count as a warning. Likewise for landuse-like tags such as leisure=park.