Modify

Opened 4 years ago

Closed 4 years ago

#2585 closed defect (fixed)

[PATCH?] Changeset [1592] breaks JOSM compilation

Reported by: avar Owned by: team
Priority: blocker Component: Core
Version: latest Keywords:
Cc:

Description

ant clean dist is required when changing function definitions like pasteData in [1592].

Attachments (1)

DuplicateAction-pasteData.patch (575 bytes) - added by avar 4 years ago.
Just set the second parameter to null when we have no source layer?

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by avar

Just set the second parameter to null when we have no source layer?

comment:1 follow-up: Changed 4 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

Set it to current layer instead.

In r1593.

I hate it that ant/java cannot track deps properly.

comment:2 in reply to: ↑ 1 Changed 4 years ago by matt_gnu

  • Resolution fixed deleted
  • Status changed from closed to reopened

curretn SVN r1593 does'nt compile yet:

[javac] .../src/org/openstreetmap/josm/actions/DuplicateAction.java:29: package Main does not exist

Index: src/org/openstreetmap/josm/actions/DuplicateAction.java
===================================================================
--- src/org/openstreetmap/josm/actions/DuplicateAction.java	(Revision 1593)
+++ src/org/openstreetmap/josm/actions/DuplicateAction.java	(Arbeitskopie)
@@ -8,6 +8,7 @@
 import java.awt.event.KeyEvent;
 import java.util.Collection;
 
+import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.CopyAction;
 import org.openstreetmap.josm.actions.PasteAction;
 import org.openstreetmap.josm.data.SelectionChangedListener;

seems a proper fix, without really knowing the josm-code ;-)

comment:3 Changed 4 years ago by stoecker

  • Resolution set to fixed
  • Status changed from reopened to closed

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.