Modify ↓

Opened 4 years ago

Closed 4 years ago

#2508 closed defect (wontfix)

[Patch]OsmPrimitive - realEqual - refactoring

Reported by: Gubaer Owned by: team
Priority: minor Component: Core
Version: latest Keywords: refactoring
Cc: karl.guggisberg@…

Description

I've been working on bugs related to conflict detection and conflict resolution and I felt that OsmPrimitive::realEqual would benefit from a minor refactoring - see attachement.

Attachments (1)

realEqual-refactoring.patch​ (2.3 KB) - added by Gubaer 4 years ago.

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by Gubaer

comment:1 Changed 4 years ago by Gubaer

  • Cc karl.guggisberg@… added

comment:2 Changed 4 years ago by stoecker

Hmm, do you really think that is an improvement?

comment:3 Changed 4 years ago by Gubaer

yes.

I agree however that it doesn't fix a bug. Nor does it add functionality. So, it probably comes down to personal taste. I'll not get angry if you don't apply the patch ;-)

comment:4 Changed 4 years ago by stoecker

  • Resolution set to wontfix
  • Status changed from new to closed

Actually I prefer the single statement variant as the chances for the compiler to optimize it are much better. So this is a wontfix. Sorry :-)

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.