Modify

Opened 4 years ago

Closed 4 years ago

#2483 closed defect (fixed)

[patch] rotate does not work under Mac OS X

Reported by: dressman Owned by: team
Priority: minor Component: Core
Version: tested Keywords:
Cc:

Description

The rotate command (crtl-shift + mouse movement) does not work; the mouse pointer changes, but the rotation does not take place. JOSM 1555 and 1529, Mac OS X 10.5.6/PPC, Java 1.5.0_16-133

Attachments (1)

rotate.patch (3.2 KB) - added by dmuecke 4 years ago.
rotate patch + platform hook

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by dmuecke

  • Owner changed from team to dmuecke
  • Status changed from new to assigned

comment:2 Changed 4 years ago by anonymous

  • Summary changed from rotate does not work under Mac OS X to [patch] rotate does not work under Mac OS X

comment:3 Changed 4 years ago by anonymous

  • Owner changed from dmuecke to team
  • Status changed from assigned to new

We have OS specific classes to catch this stuff. Please use these instead of writing OS specific code directly into the target class.

comment:4 Changed 4 years ago by dmuecke

Thanks for the advice but I can't find a good example in class PlatformHook.
Can I use something like if exists Main.pref.get("activate-mousemove") then ... ?

comment:5 Changed 4 years ago by stoecker

Ok, I had a deeper look. Actually it seems only the check whether that code is executed or not must be moved to plattform hook. So add a function boolean useActiveMouseMove() to the plattform stuff and replace the OS-check with it.

Changed 4 years ago by dmuecke

rotate patch + platform hook

comment:6 Changed 4 years ago by stoecker

  • Resolution set to fixed
  • Status changed from new to closed

In r1634.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.