#2434 closed defect (wontfix)
patch to allow empty comments in changeset [patch attached]
| Reported by: | pieren3@… | Owned by: | team |
|---|---|---|---|
| Priority: | major | Component: | Core |
| Version: | latest | Keywords: | |
| Cc: |
Description
like other editors and wikis
Attachments (2)
Change History (6)
Changed 4 years ago by pieren3@…
comment:1 Changed 4 years ago by pieren3@…
- Summary changed from Please make empty commit comment possible to patch to allow empty comments in changeset
I hope I can convince JOSM dictators that empty comments are better than rubbish comments.
If not, you can apply the attached patch into the source file OsmServerWriter.java and recompile.
comment:2 Changed 4 years ago by Schusch
well, in my opinion this patch shouldn't be added - if one has to add a comment, it will at least in most of all cases make (a litte at least) sense. But if one can omit the comment, lot's of people will use this possibility. I think it is a very good solution to have compulsory comments.
comment:3 Changed 4 years ago by framm
- Resolution set to wontfix
- Status changed from new to closed
JOSM enforcing a commit comment is by design. We want everybody to do it. Since r1546, JOSM will allow you to re-use the last commit message, and we're planning to make things even easier by keeping chnagesets open. If you do not want to enter a commit message then you will have to *actively* put a denial message in which I believe makes people think about why we're asking...
comment:4 Changed 4 years ago by pieren3@…
- Summary changed from patch to allow empty comments in changeset to patch to allow empty comments in changeset [patch attached]
To explain my request to other people reading this trac, enforcing comments it is a pure JOSM restriction decided by a single person.
The first proposal of changeset said clearly that comment is optional (proposal done by the same person!):
http://wiki.openstreetmap.org/wiki/Original_Changesets_and_Reverts_Proposal_2008
Final API documentation as well:
http://wiki.openstreetmap.org/wiki/OSM_Protocol_Version_0.6
Many comments prove as evidence if necessary that enforcing comments generate silly texts just to reach the 3 chars limits which is contra-productive.
As I said somewhere else, simply asking for comment is enough to let people thinking about comments. Enforcing create frustation as all other wiki projects understood.
Anyway, in case you don't like the current way, you can find attached a new patch against the current implementation of comment enforcement (UploadAction.java in src\org\openstreetmap\josm\actions instead of OsmServerWriter.java in src\org\openstreetmap\josm\io)
patch to allow empty comments in changeset